Add comment in test re: key algorithm inference

istio-ecosystem · Apr 15, 2024 · 75caf08 · 75caf08
1 parent a44ea63
commit 75caf08
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/internal/authz/oidc_test.go b/internal/authz/oidc_test.go
@@ -194,6 +194,9 @@ func TestOIDCProcess(t *testing.T) {
 
 	unknownJWKPriv, _ := newKeyPair(t)
 	jwkPriv, jwkPub := newKeyPair(t)
+	// We remove the optional "alg" field from this key to test that we can
+	// properly validate against them. Some providers (e.g. Microsoft Identity)
+	// exclude the "alg" field from their keys.
 	noAlgJwkPriv, noAlgJwkPub := newKeyPair(t)
 	err := noAlgJwkPriv.Set(jwk.KeyIDKey, noAlgKeyID)
 	require.NoError(t, err)