Update a few issues w.r.t jwk update and listeners. #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 1.10 Istio no longer support app listening on port localhost. Also update the doc of how to set up jwk, which could be updated. Signed-off-by: Jianfei Hu <[email protected]> Signed-off-by: Jianfei Hu <[email protected]>
|
tried to plumb through helm values for the jwk content a bit. not work well since it has some string escape issues (when using --set from helm cli, the escaped value is unescaped...) suboptimial but at least offer a way. we won't need this once jwkURI fectching is supported.. |
added 2 commits
August 20, 2021 21:39
Signed-off-by: Jianfei Hu <[email protected]> Signed-off-by: Jianfei Hu <[email protected]>
Signed-off-by: Jianfei Hu <[email protected]> Signed-off-by: Jianfei Hu <[email protected]>
lizan
approved these changes
Aug 26, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: incfly, lizan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 1.10 Istio no longer support app listening on port localhost.
Also update the doc of how to set up jwk, which could be updated.
Fix #149
Signed-off-by: Jianfei Hu [email protected]
Signed-off-by: Jianfei Hu [email protected]