-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the authservice to the Istio 1.9+ #149
Comments
Should I abandon the PR #145 and work with you on this instead? Although Ext-authz is recommended I was thinking we should still provide EnvoyFilter as a backward compatibility solution when Istio decide to change ext-authz.
2 things I am working on right now are:
Should I create a new PR for these changes? |
even though that is an experimental feature, but it's added to beta authorization policy. I would expect the performance stability can be improved as it goes to alpha beta and stable, but the API semantics should still be the same. however, envoy filter on the other hand, Istio would not maintain any promise anyway. I originally thought it's fine to add envoy filter for backward compatbility. but last version without external authz, 1.8 should be out of support already. https://istio.io/latest/docs/releases/supported-releases/. It might also confuses users for which one to choose.
I agree. this avoids the sensitive information putting in the plaintext in the config directly.
Good idea. This can also help to streamline the installation onboarding process. |
Sure, no problem. I will try to work on it in the weekend. But this is my first time contributing so it may take longer than what you expected. Anyway, regarding the new docs for istio 1.9+. I tried to implement it with httpbin and got this error in authservice/istio-proxy container. And when trying to access the Ext-authz path I only received 403 and there is no redirect to the OIDC login page. I don't think I change anything major.
|
From the log it seems like there's a cluster endpoint with name rather than IP. Not sure how it ends up like this. Have you tried the bookinfo-example/README.md with updated helm packages? This works for me. |
@anhdle14 sorry i speak too soon. you are right, there's some issues will give you 403. I already find the problems, will update the doc and config soon. |
The doc and the setup requires some setup. This issue captures the changes including
The text was updated successfully, but these errors were encountered: