Make authservice config as a Helm package. #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 13, 2021 18:40
Signed-off-by: Jianfei Hu <[email protected]>
Signed-off-by: Jianfei Hu <[email protected]>
Signed-off-by: Jianfei Hu <[email protected]>
Signed-off-by: Jianfei Hu <[email protected]>
Clarified some expectations on identity provider config and settings. Setup instructions are simplified because of Helm. Also provide config sample as standalone authservice. The in-pod-container mode can be added later. Signed-off-by: Jianfei Hu <[email protected]> Signed-off-by: Jianfei Hu <[email protected]>
… into ingress-doc Signed-off-by: Jianfei Hu <[email protected]> Signed-off-by: Jianfei Hu <[email protected]>
|
/cc @lizan @Shikugawa |
Shikugawa
reviewed
Aug 16, 2021
Signed-off-by: Jianfei Hu <[email protected]>
lizan
approved these changes
Aug 16, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: incfly, lizan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#149