Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump fileset version #7

Merged
merged 2 commits into from
Dec 19, 2016
Merged

Bump fileset version #7

merged 2 commits into from
Dec 19, 2016

Conversation

lukyth
Copy link
Contributor

@lukyth lukyth commented Oct 12, 2016

The current fileset version use [email protected] which might cause a RegExp DoS issue.

Update fileset to the latest version fix this warning.

This will resolve #6

@yahoocla
Copy link

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄

@yahoocla
Copy link

CLA is valid!

@lukyth
Copy link
Contributor Author

lukyth commented Oct 12, 2016

I've tested it and found out that the test was failed even with the old fileset version. Probably need to fix the test first.

@benediktvaldez benediktvaldez mentioned this pull request Oct 13, 2016
Closed
@jmfrancois
Copy link

Yes please @lukyth fix the tests first

@busches busches mentioned this pull request Oct 19, 2016
Merged
@montogeek
Copy link

montogeek commented Oct 31, 2016 •
edited
Loading

Tests are fixed on #9

Merge #9 first, then this one? :)

@bcoe
Copy link
Contributor

bcoe commented Dec 3, 2016

@lukyth mind rebasing with master? sounds like tests should start passing after?

@lukyth
Bump fileset version
e1beec7 
The current fileset version use [email protected] which might cause a
RegExp DoS issue.

Update fileset to the latest version fix this warning.
@lukyth lukyth force-pushed the bump_fileset_version branch from aefed3c to e1beec7 Compare December 4, 2016 03:40
@lukyth
Fix some test case
a4c7c09 
There're some test case which try to check if node_modules/adder.js is
exist, but it's not, so I fix those test cases.
@lukyth
Copy link
Contributor Author

lukyth commented Dec 5, 2016

@bcoe Done! 😄

@SimenB SimenB mentioned this pull request Dec 16, 2016
Closed
@SimenB
Copy link

SimenB commented Dec 16, 2016

@bcoe Can this get merged and released? Really annoying that deprecation warning from Jest on almost every single yarn command

@bcoe
Copy link
Contributor

bcoe commented Dec 18, 2016

@SimenB 👍 bumping to the top of my list.

@bcoe bcoe merged commit 8750735 into istanbuljs-archived-repos:master Dec 19, 2016
@bcoe
Copy link
Contributor

bcoe commented Dec 19, 2016

@lukyth thanks a ton for the contribution, I'll have a candidate release out soon and will flag the Jest folks. FYI, here's why those tests broke:

7659ef9

node_modules is excluded by default in fileset now, for the time being I removed this behavior since we already do this.

@bcoe
Copy link
Contributor

bcoe commented Dec 19, 2016

@lukyth would love the extra set of eyes testing, you should now be able to run:

npm cache clear; npm i istanbul-api@next to experiment with a candidate release that has the upgraded fileset dependency.

@lukyth lukyth deleted the bump_fileset_version branch December 20, 2016 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecated minimatch 2.0.10 will require to use fileset-2.0.2
6 participants
@lukyth @yahoocla @jmfrancois @montogeek @bcoe @SimenB