Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated minimatch 2.0.10 will require to use fileset-2.0.2 #6

Closed
ashl1 opened this issue Sep 23, 2016 · 1 comment · Fixed by #7
Closed

Deprecated minimatch 2.0.10 will require to use fileset-2.0.2 #6

ashl1 opened this issue Sep 23, 2016 · 1 comment · Fixed by #7

Comments

@ashl1
Copy link

ashl1 commented Sep 23, 2016

npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

│ ├─┬ [email protected] 
│ │ ├─┬ [email protected] 
│ │ │ ├── [email protected] 
│ │ │ └── [email protected]

While fileset-2.0.2 use appropriate minimatch-3.0.2
@fson fson mentioned this issue Sep 25, 2016
Closed
@lukyth lukyth mentioned this issue Oct 12, 2016
Merged
@benediktvaldez
Copy link

Came here because of this yarn output

warning jest > jest-cli > istanbul-api > fileset > [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

This is literally the only warning I get in my setup and I'd love it to be done – is there anything that needs to be done beyond fixing the test to merge #7 ? According to @lukyth the tests were broken even before this change.

What can I do to help? 😄

@ateev ateev mentioned this issue Oct 17, 2016
Closed
@bcoe bcoe closed this as completed in #7 Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump fileset version lukyth/istanbul-api
2 participants
@benediktvaldez @ashl1