Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for running tests on Windows #9

Merged
merged 1 commit into from
Dec 3, 2016

Conversation

busches
Copy link
Contributor

@busches busches commented Oct 19, 2016

This fixes running tests on Windows.

@bcoe
Copy link
Contributor

bcoe commented Nov 22, 2016

@busches mind rebasing; looks like you have a timeout too; you might want to pull the 5s timeout out to 10s?

@yahoocla
Copy link

CLA is valid!

@busches
Copy link
Contributor Author

busches commented Nov 22, 2016

@bcoe I can rebase, I'm a bit confused on why this wasn't just merged, since it has the exact same fixes as #12 and was done a month earlier.

This fixes running `npm test` on Windows.
@busches busches changed the title Allow for running tests on Windows and fix tests Allow for running tests on Windows Nov 22, 2016
@busches
Copy link
Contributor Author

busches commented Nov 22, 2016

Rebase is done.

@bcoe bcoe merged commit 06196e5 into istanbuljs-archived-repos:master Dec 3, 2016
@bcoe
Copy link
Contributor

bcoe commented Dec 3, 2016

@busches don't suppose I could convince you to add an appveyor config 👍

thanks a bunch for the contribution.

@busches busches deleted the fix-tests branch December 4, 2016 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants