Generate schema for isograph.config.json
#290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbalicki2
requested changes
Dec 21, 2024
| "schema" | ||
| ], | ||
| "properties": { | ||
| "$schema": { |
There was a problem hiding this comment.
lol is this a typo or is schema a special field?
There was a problem hiding this comment.
Yes, this is intentional
| @@ -95,7 +101,7 @@ struct ConfigFile { | |||
| pub schema_extensions: Vec<PathBuf>, | |||
|
|
|||
| /// Various that are of lesser importance | |||
There was a problem hiding this comment.
nit: Various options of less importance
rbalicki2
reviewed
Dec 21, 2024
| @@ -75,7 +75,7 @@ fn format_server_field_type( | |||
| fn format_field_definition( | |||
| schema: &ValidatedSchema, | |||
| name: &SelectableFieldName, | |||
| type_: &FieldType<ServerFieldId, ClientType<ClientFieldId>>, | |||
| type_: &FieldType<ServerFieldId, ClientType<ClientFieldId, ClientPointerId>>, | |||
There was a problem hiding this comment.
sorry I meant to rebase just the commits that relate to generating the schema, i.e. we shouldn't have any changes related to ☝️
What - Fixes the vite-demo tsc command How - Added the -b flag. The tsc error was about an output file not matching an input file, so by building, we ensure everything is generated so the error doesn't pop up again. I don't pretend to entirely understand exactly why, but it does work and will check types on the demo!
- document `useImperativeReference` and mutations - modify the pet demo to show the result of a mutation
Both are called with no parameters. Update docs accordingly.
# fix: Add noUncheckedIndexAccess to tsconfig ## What - Adds the `noUncheckedIndexAccess` option to the base `tsconfig.json` file - Fixes the errors that appeared - Resolves isographlabs#213 ## How - Added line to the file - Fixed issues primarily by throwing errors, as each area of the code expects it to exist and something is very wrong if it doesn't - Loosened equality checks in some places so all falsey values are caught - Changed a few `null`s to `undefined`s because accessing an index that doesn't exist (or accessing an array with `undefined` as an index value returns `undefined`)
- in makeNetworkRequest, if we pass an onComplete, we read out the result (after normalizing the data.) This gets passed to the resolver (for eager resolvers) or to getOrCreateCachedComponent (for @component resolvers). That value gets passed to onComplete - FetchOptions, as a result, must be generic, and that must be threaded through everywhere Further improvements: - makeNetworkRequest and read are doing some pretty redundant work... those should be combined - if reading the read-out value is expensive, then there should be two onComplete's: onCompleteWithReadOutValue and onComplete. However, this can be added later (if necessary)
…ph into generate-json-schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.