fix: Add noUncheckedIndexAccess to tsconfig #281
Conversation
|
@rbalicki2 Did my best on the error throwing messages, let me know if you have more informative ones in mind! |
libs/isograph-react/src/core/read.ts
Outdated
| const resolverRefetchQueries = usedRefetchQueries.map((index) => { | ||
| const resolverRefetchQuery = nestedRefetchQueries[index]; | ||
| if (resolverRefetchQuery == null) { | ||
| throw new Error('resolverRefetchQuery is null in Resolver'); |
There was a problem hiding this comment.
Can you please add this is indicative of a bug in Isograph?
libs/isograph-react/src/core/read.ts
Outdated
| @@ -343,9 +343,12 @@ function readData<TReadFromStore>( | |||
| } else { | |||
| const refetchQueryIndex = field.refetchQuery; | |||
| if (refetchQueryIndex == null) { | |||
There was a problem hiding this comment.
oops, this can never be null... the field is not optional. This is probably a holdover from a previous time. perhaps something like https://typescript-eslint.io/rules/no-unnecessary-condition/ can prevent this in the future
libs/isograph-react/src/core/read.ts
Outdated
| } | ||
| const refetchQuery = nestedRefetchQueries[refetchQueryIndex]; | ||
| if (refetchQuery == null) { | ||
| throw new Error('refetchQuery is null in RefetchField'); |
There was a problem hiding this comment.
Can you add that this is indicative of a bug in Isograph
libs/isograph-react/src/core/read.ts
Outdated
| childVars[name] = variables[value.name]; | ||
| const variable = variables[value.name]; | ||
| if (variable == null) { | ||
| throw new Error('Variable ' + value.name + ' is not missing'); |
There was a problem hiding this comment.
s/not missing/missing
But also, this breaks if we have a default value for a variable and the variable is not provided, e.g. field Query.PetDetailRoute($id: ID = 4) @component { with no variable provided.
I think the appropriate behavior is to continue the loop, i.e. we don't (currently) distinguish between missing and null variables, so skipping the variable is appropriate (and based on my limited testing, works)
There was a problem hiding this comment.
Oh ChatGPT, thank you for being awful lol. I did not even see the "not" lol
And that logic makes sense! Will just allow the loop to continue.
| @@ -114,8 +114,13 @@ export function useConnectionSpecPagination< | |||
| fragmentReference.readerWithRefetchQueries, | |||
| ); | |||
|
|
|||
| const data = readOutDataAndRecords[i]?.item; | |||
| if (data == null) { | |||
| throw new Error('Parameter data is unexpectedly null'); | |||
There was a problem hiding this comment.
indicative of a bug in isograph, likewise below and in useSkipLimit. Could you also add a comment // invariant: readOutDataAndRecords.length === completedReferences.length somewhere near here as well?
# fix: Add noUncheckedIndexAccess to tsconfig ## What - Adds the `noUncheckedIndexAccess` option to the base `tsconfig.json` file - Fixes the errors that appeared - Resolves isographlabs#213 ## How - Added line to the file - Fixed issues primarily by throwing errors, as each area of the code expects it to exist and something is very wrong if it doesn't - Loosened equality checks in some places so all falsey values are caught - Changed a few `null`s to `undefined`s because accessing an index that doesn't exist (or accessing an array with `undefined` as an index value returns `undefined`)
# fix: Add noUncheckedIndexAccess to tsconfig ## What - Adds the `noUncheckedIndexAccess` option to the base `tsconfig.json` file - Fixes the errors that appeared - Resolves isographlabs#213 ## How - Added line to the file - Fixed issues primarily by throwing errors, as each area of the code expects it to exist and something is very wrong if it doesn't - Loosened equality checks in some places so all falsey values are caught - Changed a few `null`s to `undefined`s because accessing an index that doesn't exist (or accessing an array with `undefined` as an index value returns `undefined`)
fix: Add noUncheckedIndexAccess to tsconfig
What
noUncheckedIndexAccessoption to the basetsconfig.jsonfileHow
nulls toundefineds because accessing an index that doesn't exist (or accessing an array withundefinedas an index value returnsundefined)