fix(signature-collection): hide view list while active #16474
Conversation
WalkthroughThe changes in this pull request focus on the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)
🔇 Additional comments (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
- libs/portals/admin/signature-collection/src/screens-parliamentary/Constituency/index.tsx (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
libs/portals/admin/signature-collection/src/screens-parliamentary/Constituency/index.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
🔇 Additional comments (1)
libs/portals/admin/signature-collection/src/screens-parliamentary/Constituency/index.tsx (1)
33-35: LGTM: Import statement refactored for better readability.The change to a block import style for
SignatureCollectionListimproves code readability and follows common import conventions. It's a good practice to import from the API schema as it ensures type consistency across the application.
libs/portals/admin/signature-collection/src/screens-parliamentary/Constituency/index.tsx
Show resolved
Hide resolved
Datadog ReportAll test runs ✅ 88 Total Test Services: 0 Failed, 85 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (7)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16474 +/- ##
==========================================
- Coverage 36.75% 36.73% -0.03%
==========================================
Files 6835 6835
Lines 141332 141509 +177
Branches 40240 40295 +55
==========================================
+ Hits 51949 51980 +31
- Misses 89383 89529 +146 Flags with carried forward coverage won't be shown. Click here to find out more. see 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes