fix(parliamentary): minor text updates and cleanup #15815
Conversation
WalkthroughThe changes involve updates to message definitions across several files, focusing on translations into Icelandic and modifications to user interface components. Key alterations include replacing placeholder text with relevant instructions, removing certain fields from forms, and adjusting the layout of components to streamline information display. These modifications enhance clarity and user interaction within the application. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
albinagu
added
the
deprecated:automerge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15815 +/- ##
=======================================
Coverage 36.96% 36.96%
=======================================
Files 6635 6635
Lines 136023 136023
Branches 38735 38735
=======================================
Hits 50280 50280
Misses 85743 85743
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (7)
- libs/application/templates/signature-collection/parliamentary-list-creation/src/lib/messages.ts (1 hunks)
- libs/application/templates/signature-collection/parliamentary-list-signing/src/forms/Done.ts (1 hunks)
- libs/application/templates/signature-collection/parliamentary-list-signing/src/lib/messages.ts (1 hunks)
- libs/service-portal/signature-collection/src/lib/messages.ts (2 hunks)
- libs/service-portal/signature-collection/src/screens/Parliamentary/OwnerView/index.tsx (2 hunks)
- libs/service-portal/signature-collection/src/screens/Parliamentary/OwnerView/modals/AddConstituency/index.tsx (2 hunks)
- libs/service-portal/signature-collection/src/screens/Parliamentary/OwnerView/modals/DeletePerson/index.tsx (1 hunks)
Files skipped from review due to trivial changes (1)
- libs/service-portal/signature-collection/src/screens/Parliamentary/OwnerView/modals/AddConstituency/index.tsx
Additional context used
Path-based instructions (6)
libs/service-portal/signature-collection/src/screens/Parliamentary/OwnerView/modals/DeletePerson/index.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/signature-collection/parliamentary-list-signing/src/forms/Done.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/service-portal/signature-collection/src/screens/Parliamentary/OwnerView/index.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/signature-collection/parliamentary-list-signing/src/lib/messages.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/signature-collection/parliamentary-list-creation/src/lib/messages.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/service-portal/signature-collection/src/lib/messages.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Additional comments not posted (9)
libs/service-portal/signature-collection/src/screens/Parliamentary/OwnerView/modals/DeletePerson/index.tsx (1)
18-20: LGTM!The addition of the formatted message
m.deleteas a child element to theButtoncomponent improves user interaction and clarity.libs/application/templates/signature-collection/parliamentary-list-signing/src/forms/Done.ts (1)
Line range hint
1-1: Verify the impact of the removal of description fields.The removal of the
buildDescriptionFieldcomponents withid: 'nextStepsTitle'andid: 'nextStepsDescription'may impact the user experience by providing less information. Ensure that the form still provides sufficient guidance to the users.libs/service-portal/signature-collection/src/screens/Parliamentary/OwnerView/index.tsx (2)
139-139: LGTM!The specified width of '30%' for the
T.Datacomponent for the person name is a reasonable adjustment to the table layout.
141-142: LGTM!The change from
spaceBetweentoflexEndfor theBoxcomponent'sjustifyContentproperty improves the visual alignment of theDeletePersoncomponent within the table cell.libs/application/templates/signature-collection/parliamentary-list-signing/src/lib/messages.ts (1)
189-191: LGTM!The updated message is more user-centric and provides clearer guidance to the user.
libs/application/templates/signature-collection/parliamentary-list-creation/src/lib/messages.ts (1)
85-87: LGTM!The updated message is contextually appropriate and provides clear instructions to the user.
libs/service-portal/signature-collection/src/lib/messages.ts (3)
325-327: LGTM!The updated message is contextually appropriate and provides clear instructions to the user.
336-338: LGTM!The updated message is more accurate and reflects the intended action.
342-344: LGTM!The updated message is more accurate and reflects the intended action.
Datadog ReportAll test runs ✅ 4 Total Test Services: 0 Failed, 4 Passed Test Services
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- libs/service-portal/signature-collection/src/screens/Parliamentary/OwnerView/modals/AddConstituency/index.tsx (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- libs/service-portal/signature-collection/src/screens/Parliamentary/OwnerView/modals/AddConstituency/index.tsx
…is/island.is into collection_parliamentary
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- libs/service-portal/signature-collection/src/lib/messages.ts (4 hunks)
- libs/service-portal/signature-collection/src/screens/Parliamentary/OwnerView/index.tsx (3 hunks)
- libs/service-portal/signature-collection/src/screens/Parliamentary/index.tsx (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- libs/service-portal/signature-collection/src/screens/Parliamentary/OwnerView/index.tsx
Additional context used
Path-based instructions (2)
libs/service-portal/signature-collection/src/screens/Parliamentary/index.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/service-portal/signature-collection/src/lib/messages.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Additional comments not posted (8)
libs/service-portal/signature-collection/src/screens/Parliamentary/index.tsx (2)
3-3: LGTM!The import statement now includes
THJODSKRA_SLUG, which is used within the component. This change is appropriate and enhances the functionality.
13-19: LGTM!The
IntroHeadercomponent now includesserviceProviderTooltipandserviceProviderSlugprops, providing additional contextual information. TheBoxcomponent withdisplayset to'flex'may affect the layout positively.libs/service-portal/signature-collection/src/lib/messages.ts (6)
34-36: LGTM!The updated message for
myListsDescriptionprovides a clearer and more contextually appropriate translation in Icelandic.
37-39: LGTM!The updated message for
myListsInfoprovides a clearer and more contextually appropriate translation in Icelandic.
269-271: LGTM!The updated message for
pageDescriptionParliamentaryprovides a clearer and more contextually appropriate translation in Icelandic.
272-276: LGTM!The new message identifier
infoProviderTooltipprovides additional contextual information about the service provider, enhancing the user interface.
335-337: LGTM!The updated message for
addConstituencyDescriptionprovides a clearer and more contextually appropriate translation in Icelandic.
346-352: LGTM!The updated messages for
deleteManageranddeleteManagerDescriptionprovide clearer and more contextually appropriate translations in Icelandic.
* fix(parliamentary): minor text updates and cleanup * chore: nx format:write update dirty files * tooltips * Update libs/service-portal/signature-collection/src/lib/messages.ts --------- Co-authored-by: andes-it <[email protected]> Co-authored-by: kksteini <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes
Documentation