fix(auth-admin-api): Fix delegation type reset when adding new type

[saevarma]

What

Only toggle boolean fields for added types.

Why

To stop reset currently configured fields, causing issues for users.

Screenshots / Gifs

N/A

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• Chores
  • Improved the clarity and maintainability of the client update process by conditionally including properties in updates.

[coderabbitai]

Walkthrough

The pull request introduces changes to the ClientsService class, specifically modifying the update method to utilize a conditional approach for updating multiple boolean properties. Instead of directly assigning values to the update object, the new implementation uses the spread operator to include properties only if their values are truthy. This approach aims to enhance the clarity and maintainability of the code.

Changes

File Path	Change Summary
libs/auth-api-lib/src/lib/clients/clients.service.ts	Updated the update method in ClientsService to conditionally include boolean properties using the spread operator.

Possibly related PRs

• fix(services-auth-admin-api): Fix delegation settings #15968: This PR modifies the AdminScopeService class to use a conditional approach with the spread operator for updating properties, similar to the changes made in the ClientsService class in the main PR.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[GunnlaugurG]

LGTM 🚀

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.81%. Comparing base (28c73a0) to head (e7aab30).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...bs/auth-api-lib/src/lib/clients/clients.service.ts	80.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #16016   +/-   ##
=======================================
  Coverage   36.81%   36.81%           
=======================================
  Files        6721     6721           
  Lines      137874   137878    +4     
  Branches    39199    39204    +5     
=======================================
+ Hits        50757    50763    +6     
+ Misses      87117    87115    -2     

Flag	Coverage Δ
api	3.39% <ø> (ø)
api-domains-auth-admin	49.89% <ø> (ø)
application-system-api	41.67% <ø> (ø)
application-template-api-modules	23.44% <ø> (-0.02%)	⬇️
services-auth-admin-api	52.85% <80.00%> (+0.01%)	⬆️
services-auth-delegation-api	61.29% <0.00%> (-0.11%)	⬇️
services-auth-ids-api	54.01% <0.00%> (-0.01%)	⬇️
services-auth-personal-representative	47.96% <0.00%> (+0.01%)	⬆️
services-auth-personal-representative-public	43.88% <0.00%> (-0.04%)	⬇️
services-auth-public-api	51.80% <0.00%> (-0.03%)	⬇️
services-user-notification	47.61% <ø> (ø)
services-user-profile	62.18% <ø> (-0.08%)	⬇️
web	1.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...bs/auth-api-lib/src/lib/clients/clients.service.ts	30.26% <80.00%> (+1.11%)	⬆️

... and 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28c73a0...e7aab30. Read the comment docs.

[datadog-island-is]

Datadog Report

All test runs 345f809 🔗

✅ 14 Total Test Services: 0 Failed, 14 Passed
🔻 Test Sessions change in coverage: 2 decreased, 1 increased (+0.02%), 22 no change

Test Services

This report shows up to 10 services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
api	0	0	0	4	0	2.65s	1 no change	Link
api-domains-auth-admin	0	0	0	18	0	11.95s	1 no change	Link
application-system-api	0	0	0	111	2	2m 53.72s	1 no change	Link
application-template-api-modules	0	0	0	109	0	1m 44.89s	1 no change	Link
auth-api-lib	0	0	0	20	0	37.7s	1 no change	Link
services-auth-admin-api	0	0	0	107	0	3m 0.09s	1 no change	Link
services-auth-delegation-api	0	0	0	256	0	3m 0.63s	1 decreased (-0.26%)	Link
services-auth-ids-api	0	0	0	145	0	59.1s	1 no change	Link
services-auth-personal-representative	0	0	0	59	0	1m 19.31s	1 increased (+0.02%)	Link
services-auth-personal-representative-public	0	0	0	10	0	27.59s	1 no change	Link

🔻 Code Coverage Decreases vs Default Branch (2)

• services-auth-delegation-api - jest 60.04% (-0.26%) - Details
• services-user-profile - jest 52.67% (-0.02%) - Details