fix(services-auth-admin-api): Fix delegation settings

[saevarma]

What

When adding delegation type to scope it resetted all missing types to false.

Why

To fix the bug caused by this reverting delegation types not in the array to false.

Screenshots / Gifs

N/A

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features
  • Enhanced test coverage for updating delegation settings in the API scope.
• Improvements
  • Improved data handling in the AdminScopeService by conditionally including properties in the update method, leading to cleaner updates and reduced risk of unintended data issues.

[coderabbitai]

Walkthrough

The changes consist of enhancements to the test suite for the MeScopesController, specifically adding a test case for updating delegation settings of an API scope. Additionally, the AdminScopeService class has been modified to improve how properties are passed to the update method, utilizing a spread operator with conditional checks to include properties only if their values are truthy.

Changes

Files	Change Summary
apps/services/auth/admin-api/src/app/v2/scopes/test/me-scopes.spec.ts	Added a new test case for updating delegation settings in the MeScopesController test suite.
libs/auth-api-lib/src/lib/resources/admin/admin-scope.service.ts	Modified the update method to use a spread operator with conditional checks for property inclusion.

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6200a9a and 9c5e326.

Files selected for processing (2)

• apps/services/auth/admin-api/src/app/v2/scopes/test/me-scopes.spec.ts (4 hunks)
• libs/auth-api-lib/src/lib/resources/admin/admin-scope.service.ts (1 hunks)

Files skipped from review as they are similar to previous changes (2)

• apps/services/auth/admin-api/src/app/v2/scopes/test/me-scopes.spec.ts
• libs/auth-api-lib/src/lib/resources/admin/admin-scope.service.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.86%. Comparing base (8eb83b6) to head (9c5e326).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #15968   +/-   ##
=======================================
  Coverage   36.86%   36.86%           
=======================================
  Files        6714     6714           
  Lines      137605   137611    +6     
  Branches    39113    39119    +6     
=======================================
+ Hits        50723    50732    +9     
+ Misses      86882    86879    -3     

Flag	Coverage Δ
api	3.39% <ø> (ø)
api-domains-auth-admin	49.89% <ø> (ø)
application-system-api	41.70% <ø> (ø)
application-template-api-modules	23.49% <ø> (ø)
services-auth-admin-api	52.80% <100.00%> (+0.08%)	⬆️
services-auth-delegation-api	61.39% <0.00%> (-0.04%)	⬇️
services-auth-ids-api	54.05% <0.00%> (-0.03%)	⬇️
services-auth-personal-representative	47.98% <0.00%> (+<0.01%)	⬆️
services-auth-personal-representative-public	43.91% <0.00%> (-0.03%)	⬇️
services-auth-public-api	51.82% <0.00%> (-0.04%)	⬇️
services-user-notification	47.74% <ø> (ø)
services-user-profile	62.19% <ø> (-0.08%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...lib/src/lib/resources/admin/admin-scope.service.ts	90.28% <100.00%> (+1.52%)	⬆️

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eb83b6...9c5e326. Read the comment docs.

[datadog-island-is]

Datadog Report

All test runs d416a33 🔗

✅ 13 Total Test Services: 0 Failed, 13 Passed
🔻 Test Sessions change in coverage: 1 decreased (-0.02%), 1 increased (+0.05%), 22 no change

Test Services

This report shows up to 10 services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
api	0	0	0	4	0	2.76s	1 no change	Link
api-domains-auth-admin	0	0	0	18	0	12.06s	1 no change	Link
application-system-api	0	0	0	111	2	3m 20.72s	1 no change	Link
application-template-api-modules	0	0	0	109	0	1m 51.63s	1 no change	Link
auth-api-lib	0	0	0	20	0	27.61s	1 no change	Link
services-auth-admin-api	0	0	0	107	0	2m 51.84s	1 increased (+0.05%)	Link
services-auth-delegation-api	0	0	0	256	0	2m 43.54s	1 no change	Link
services-auth-ids-api	0	0	0	145	0	57.39s	1 no change	Link
services-auth-personal-representative	0	0	0	59	0	1m 21.9s	1 no change	Link
services-auth-personal-representative-public	0	0	0	10	0	26.44s	1 no change	Link

🔻 Code Coverage Decreases vs Default Branch (1)

• services-user-profile - jest 52.67% (-0.02%) - Details