feat(application-plc): Procuration #15945

kksteini · 2024-09-10T15:27:22Z

...

Attach a link to issue if relevant

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

I have performed a self-review of my own code
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Formatting passes locally with my changes
I have rebased against main before asking for a review

Summary by CodeRabbit

New Features
- Integrated National Registry service for enhanced identity verification in parliamentary list creation.
- Added a new method to retrieve individual identities based on national ID.
- Introduced ParliamentaryIdentityApi for handling parliamentary identity actions.
Improvements
- Enhanced form data handling for applicant's full name and national ID.
- Updated data providers in forms to support new identity verification functionalities.
Bug Fixes
- Simplified user eligibility checks for signature creation by removing national ID validation.

coderabbitai · 2024-09-10T15:27:28Z

Walkthrough

The pull request introduces several modifications to the ParliamentaryListCreationModule, enhancing its integration with the national registry service. Key changes include the addition of the NationalRegistryClientModule and NationalRegistryClientService, updates to the ParliamentaryListCreationService to include a new method for retrieving identities, and the introduction of the ParliamentaryIdentityApi for handling parliamentary identities. Additionally, adjustments were made to various forms and services to accommodate these new functionalities, reflecting a comprehensive enhancement of the module's capabilities.

Changes

File	Change Summary
`.../parliamentary-list-creation/parliamentary-list-creation.module.ts`	Added `NationalRegistryClientModule` and `NationalRegistryClientService` to the module for national registry integration.
`.../parliamentary-list-creation/parliamentary-list-creation.service.ts`	Introduced `parliamentaryIdentity` method for identity retrieval from the National Registry; modified `submit` method for owner property population.
`.../parliamentary-list-creation/src/dataProviders/index.ts`	Added `ParliamentaryIdentityApi` for handling parliamentary identity actions.
`.../parliamentary-list-creation/src/forms/Draft.ts`	Updated default values for `fullName` and national ID fields to reflect new data sources and improve robustness in handling applicant actors.
`.../parliamentary-list-creation/src/forms/Prerequisites.ts`	Added `ParliamentaryIdentityApi` as a new data provider and reorganized existing data provider items in the form.
`.../parliamentary-list-creation/src/lib/createCollectionTemplate.ts`	Included `ParliamentaryIdentityApi` in the `createListTemplate` function's parameters to enhance template creation capabilities.
`.../signature-collection/src/lib/signature-collection.service.ts`	Removed national ID validation check in user ownership verification, simplifying control flow and modifying eligibility retrieval logic.

Possibly related PRs

fix(application-plc): Incorrect assumption for dataprovider #15917: Modifies ParliamentaryListCreationService, affecting how it processes candidates and their national IDs, directly related to the main PR.
feat(id-card): updates to application #15870: Although this PR focuses on the NationalRegistryService, it involves logic related to national IDs, which is a key aspect of the main PR's changes in the ParliamentaryListCreationService and ParliamentaryListCreationModule.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-09-10T15:40:28Z

Deployed services: application-system-api,application-system-form,api,application-system-api-worker,consultation-portal,web.
Excluded services: ``

codecov · 2024-09-10T15:44:37Z

Codecov Report

Attention: Patch coverage is 36.84211% with 12 lines in your changes missing coverage. Please review.

Project coverage is 36.85%. Comparing base (7651100) to head (75aa9c5).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...st-creation/parliamentary-list-creation.service.ts	26.66%	11 Missing ⚠️
...collection/src/lib/signature-collection.service.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #15945    +/-   ##
========================================
  Coverage   36.84%   36.85%            
========================================
  Files        6718     6713     -5     
  Lines      137693   137574   -119     
  Branches    39143    39127    -16     
========================================
- Hits        50739    50706    -33     
+ Misses      86954    86868    -86

Flag	Coverage Δ
air-discount-scheme-backend	`54.07% <ø> (ø)`
air-discount-scheme-web	`0.00% <ø> (ø)`
api	`3.39% <ø> (ø)`
api-domains-air-discount-scheme	`36.85% <ø> (ø)`
api-domains-assets	`26.71% <ø> (ø)`
api-domains-auth-admin	`49.89% <ø> (ø)`
api-domains-communications	`40.42% <ø> (ø)`
api-domains-criminal-record	`47.77% <ø> (ø)`
api-domains-driving-license	`44.27% <ø> (ø)`
api-domains-education	`31.22% <ø> (ø)`
api-domains-health-insurance	`34.58% <ø> (ø)`
api-domains-mortgage-certificate	`35.73% <ø> (ø)`
api-domains-payment-schedule	`41.14% <ø> (ø)`
application-api-files	`57.46% <ø> (ø)`
application-core	`72.33% <ø> (ø)`
application-system-api	`41.67% <36.84%> (-0.01%)`	⬇️
application-template-api-modules	`23.47% <0.00%> (-0.01%)`	⬇️
application-templates-accident-notification	`22.26% <ø> (ø)`
application-templates-car-recycling	`3.12% <ø> (ø)`
application-templates-criminal-record	`26.96% <ø> (ø)`
application-templates-driving-license	`18.75% <ø> (ø)`
application-templates-estate	`12.55% <ø> (ø)`
application-templates-example-payment	`25.72% <ø> (ø)`
application-templates-financial-aid	`14.39% <ø> (ø)`
application-templates-general-petition	`23.95% <ø> (ø)`
application-templates-health-insurance	`26.88% <ø> (ø)`
application-templates-inheritance-report	`6.45% <ø> (ø)`
application-templates-marriage-conditions	`15.35% <ø> (ø)`
application-templates-mortgage-certificate	`44.15% <ø> (ø)`
application-templates-parental-leave	`29.31% <ø> (+0.11%)`	⬆️
application-types	`6.74% <ø> (ø)`
application-ui-components	`1.52% <ø> (ø)`
application-ui-shell	`21.75% <ø> (ø)`
clients-charge-fjs-v2	`24.11% <ø> (ø)`
clients-driving-license	`40.56% <ø> (ø)`
clients-driving-license-book	`43.85% <ø> (ø)`
clients-financial-statements-inao	`49.10% <ø> (ø)`
clients-license-client	`1.83% <ø> (ø)`
clients-regulations	`42.54% <ø> (ø)`
clients-rsk-company-registry	`29.76% <ø> (ø)`
clients-rsk-personal-tax-return	`38.00% <ø> (ø)`
clients-smartsolutions	`12.77% <ø> (ø)`
clients-syslumenn	`49.75% <ø> (ø)`
cms	`0.42% <ø> (ø)`
cms-translations	`39.57% <ø> (ø)`
dokobit-signing	`62.85% <ø> (ø)`
download-service	`44.55% <ø> (ø)`
email-service	`60.65% <ø> (ø)`
feature-flags	`90.69% <ø> (ø)`
file-storage	`53.01% <ø> (ø)`
financial-aid-backend	`56.52% <ø> (ø)`
judicial-system-api	`19.35% <ø> (ø)`
judicial-system-audit-trail	`68.53% <ø> (ø)`
judicial-system-backend	`55.72% <ø> (ø)`
judicial-system-message	`66.79% <ø> (ø)`
judicial-system-message-handler	`47.61% <ø> (ø)`
judicial-system-scheduler	`68.98% <ø> (ø)`
license-api	`42.76% <ø> (-0.16%)`	⬇️
nest-config	`78.07% <ø> (ø)`
nest-feature-flags	`51.25% <ø> (-0.66%)`	⬇️
nova-sms	`62.18% <ø> (ø)`
portals-admin-regulations-admin	`1.96% <ø> (ø)`
portals-core	`16.14% <ø> (ø)`
services-auth-admin-api	`52.83% <ø> (ø)`
services-auth-delegation-api	`61.39% <ø> (+0.07%)`	⬆️
services-auth-ids-api	`54.01% <ø> (-0.02%)`	⬇️
services-auth-personal-representative	`47.98% <ø> (ø)`
services-auth-personal-representative-public	`43.84% <ø> (-0.06%)`	⬇️
services-auth-public-api	`51.81% <ø> (ø)`
services-endorsements-api	`54.98% <ø> (ø)`
services-sessions	`65.79% <ø> (+0.04%)`	⬆️
services-university-gateway	`48.48% <ø> (+0.08%)`	⬆️
services-user-notification	`47.61% <ø> (+0.03%)`	⬆️
services-user-profile	`62.25% <ø> (ø)`
web	`1.85% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ist-creation/parliamentary-list-creation.module.ts	`100.00% <100.00%> (ø)`
...iamentary-list-creation/src/dataProviders/index.ts	`100.00% <100.00%> (ø)`
...-list-creation/src/lib/createCollectionTemplate.ts	`50.00% <100.00%> (ø)`
...collection/src/lib/signature-collection.service.ts	`8.52% <0.00%> (+0.09%)`	⬆️
...st-creation/parliamentary-list-creation.service.ts	`30.50% <26.66%> (-1.31%)`	⬇️

... and 21 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7651100...75aa9c5. Read the comment docs.

datadog-island-is · 2024-09-10T15:45:00Z

Datadog Report

All test runs aae754d 🔗

✅ 70 Total Test Services: 0 Failed, 68 Passed
🔻 Test Sessions change in coverage: 3 decreased, 3 increased, 194 no change

Test Services

This report shows up to 10 services

Service Name	Passed	Total Time	Code Coverage Change	Test Service View
`air-discount-scheme-backend`	81	29.68s	N/A	Link
`air-discount-scheme-web`	2	8.07s	1 no change	Link
`api`	4	2.93s	N/A	Link
`api-domains-air-discount-scheme`	6	20.56s	1 no change	Link
`api-domains-assets`	3	12.5s	1 no change	Link
`api-domains-auth-admin`	18	12.14s	N/A	Link
`api-domains-communications`	5	27.51s	1 no change	Link
`api-domains-criminal-record`	5	8.63s	1 no change	Link
`api-domains-driving-license`	23	32.57s	1 no change	Link
`api-domains-education`	8	21.92s	1 no change	Link

🔻 Code Coverage Decreases vs Default Branch (3)

nest-feature-flags - jest 57.3% (-0.47%) - Details
services-auth-personal-representative-public - jest 45.88% (-0.04%) - Details
license-api - jest 33.87% (-0.03%) - Details

…-procuration

feat(application-plc): Procuration

9490203

kksteini added the deploy-feature Deploys features to dev label Sep 10, 2024

kksteini marked this pull request as ready for review September 12, 2024 08:51

kksteini requested a review from a team as a code owner September 12, 2024 08:51

Merge branch 'main' into feat/application-parliamentary-list-creation…

2f90e4d

…-procuration

kksteini added automerge Merge this PR as soon as all checks pass and removed deploy-feature Deploys features to dev labels Sep 12, 2024

coderabbitai bot approved these changes Sep 12, 2024

View reviewed changes

let→const

4011e5f

juni-haukur approved these changes Sep 13, 2024

View reviewed changes

Merge branch 'main' into feat/application-parliamentary-list-creation…

75aa9c5

…-procuration

kodiakhq bot merged commit c48134d into main Sep 13, 2024
197 checks passed

kodiakhq bot deleted the feat/application-parliamentary-list-creation-procuration branch September 13, 2024 11:19

coderabbitai bot mentioned this pull request Sep 25, 2024

fix(signature-collection): sign list without candidateid #16154

Merged

6 tasks

This was referenced Oct 16, 2024

fix(application-plc): Detect user delegation type #16429

Merged

fix(signature-collection): try catch not found #16447

Merged

coderabbitai bot mentioned this pull request Nov 8, 2024

feat(transfer-of-machine-ownership): aosh ondelete #16784

Merged

6 tasks

coderabbitai bot mentioned this pull request Nov 27, 2024

feat(identity api): Add includeActorInfo parameter #17037

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(application-plc): Procuration #15945

feat(application-plc): Procuration #15945

kksteini commented Sep 10, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 10, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

github-actions bot commented Sep 10, 2024

codecov bot commented Sep 10, 2024 •

edited

Loading

datadog-island-is bot commented Sep 10, 2024 •

edited

Loading

feat(application-plc): Procuration #15945

feat(application-plc): Procuration #15945

Conversation

kksteini commented Sep 10, 2024 • edited by coderabbitai bot Loading

...

What

Why

Screenshots / Gifs

Checklist:

Summary by CodeRabbit

coderabbitai bot commented Sep 10, 2024 • edited Loading

Walkthrough

Changes

Possibly related PRs

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

github-actions bot commented Sep 10, 2024

codecov bot commented Sep 10, 2024 • edited Loading

Codecov Report

datadog-island-is bot commented Sep 10, 2024 • edited Loading

Datadog Report

🔻 Code Coverage Decreases vs Default Branch (3)

kksteini commented Sep 10, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 10, 2024 •

edited

Loading

codecov bot commented Sep 10, 2024 •

edited

Loading

datadog-island-is bot commented Sep 10, 2024 •

edited

Loading