fix(shared-utils): Fix addressing in getConfigValue (#16358)

* fix(shared-utils): Fix addressing in getConfigValue * Fix tests --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
island-is · Oct 10, 2024 · ca1cc4e · ca1cc4e
1 parent 0c4b341
commit ca1cc4e
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 28 deletions.
diff --git a/libs/application/template-api-modules/src/lib/modules/shared/shared.utils.spec.ts b/libs/application/template-api-modules/src/lib/modules/shared/shared.utils.spec.ts
@@ -3,30 +3,32 @@ import { ConfigService } from '@nestjs/config'
 import * as utils from './shared.utils'
 
 const mockConfig = {
-  clientLocationOrigin: 'http://localhost:4242',
-  baseApiUrl: 'http://localhost:4444',
-  attachmentBucket: 'attachmentBucket',
-  templateApi: {
-    clientLocationOrigin: 'http://localhost:4242/umsoknir',
-    email: {
-      sender: 'Devland.is',
-      address: '[email protected]',
-    },
-    jwtSecret: 'supersecret',
-    xRoadBasePathWithEnv: '',
+  SharedModuleConfig: {
+    clientLocationOrigin: 'http://localhost:4242',
     baseApiUrl: 'http://localhost:4444',
-    presignBucket: '',
-    attachmentBucket: 'island-is-dev-storage-application-system',
-    generalPetition: {
-      endorsementApiBasePath: 'http://localhost:4246',
-    },
-    userProfile: {
-      serviceBasePath: 'http://localhost:3366',
-    },
-    islykill: {
-      cert: '',
-      passphrase: '',
-      basePath: '',
+    attachmentBucket: 'attachmentBucket',
+    templateApi: {
+      clientLocationOrigin: 'http://localhost:4242/umsoknir',
+      email: {
+        sender: 'Devland.is',
+        address: '[email protected]',
+      },
+      jwtSecret: 'supersecret',
+      xRoadBasePathWithEnv: '',
+      baseApiUrl: 'http://localhost:4444',
+      presignBucket: '',
+      attachmentBucket: 'island-is-dev-storage-application-system',
+      generalPetition: {
+        endorsementApiBasePath: 'http://localhost:4246',
+      },
+      userProfile: {
+        serviceBasePath: 'http://localhost:3366',
+      },
+      islykill: {
+        cert: '',
+        passphrase: '',
+        basePath: '',
+      },
     },
   },
 }
@@ -92,7 +94,7 @@ describe('shared utils', () => {
   let configService: ConfigService<SharedModuleConfig>
 
   beforeEach(() => {
-    configService = new ConfigService<SharedModuleConfig>(mockConfig)
+    configService = new ConfigService(mockConfig)
   })
 
   it('should get the client location origin from the config', () => {

diff --git a/libs/application/template-api-modules/src/lib/modules/shared/shared.utils.ts b/libs/application/template-api-modules/src/lib/modules/shared/shared.utils.ts
@@ -25,10 +25,10 @@ export const createAssignToken = (
 }
 
 export const getConfigValue = (
-  configService: ConfigService<SharedModuleConfig>,
+  configService: ConfigService,
   key: keyof SharedModuleConfig,
 ) => {
-  const value = configService.get(key)
+  const value = configService.get(`SharedModuleConfig.${key}`)
 
   if (value === undefined) {
     throw new Error(

diff --git a/...templates/social-insurance-administration/social-insurance-administration.service.spec.ts b/...templates/social-insurance-administration/social-insurance-administration.service.spec.ts
@@ -8,8 +8,10 @@ import { ApplicationTypes } from '@island.is/application/types'
 import { sharedModuleConfig } from '../../shared'
 
 const mockConfig = {
-  templateApi: {
-    attachmentBucket: 'island-is-dev-storage-application-system',
+  SharedModuleConfig: {
+    templateApi: {
+      attachmentBucket: 'island-is-dev-storage-application-system',
+    },
   },
 }