log the response in resource and request in meta

island-is · Oct 10, 2024 · 9e16ff4 · 9e16ff4
1 parent 6449052
commit 9e16ff4
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 3 deletions.
diff --git a/apps/services/auth/admin-api/src/app/v2/delegations/delegation-admin.controller.ts b/apps/services/auth/admin-api/src/app/v2/delegations/delegation-admin.controller.ts
@@ -106,7 +106,24 @@ export class DelegationAdminController {
   async createByZendeskId(
     @Body() { id }: ZendeskWebhookInputDto,
   ): Promise<void> {
-    await this.delegationAdminService.createDelegationByZendeskId(id)
+    await this.auditService.auditPromise(
+      {
+        system: true,
+        namespace,
+        action: 'createByZendeskId',
+        resources: (res) => {
+          return `id: ${res.id}, toNationalId: ${
+            res.toNationalId ?? 'Unknown'
+          }, fromNationalId: ${
+            res.fromNationalId ?? 'Unknown'
+          }, createdByNationalId: ${res.createdByNationalId ?? 'Unknown'}`
+        },
+        meta: {
+          id,
+        },
+      },
+      this.delegationAdminService.createDelegationByZendeskId(id),
+    )
   }
 
   @Delete(':delegationId')

diff --git a/libs/auth-api-lib/src/lib/delegations/admin/delegation-admin-custom.service.ts b/libs/auth-api-lib/src/lib/delegations/admin/delegation-admin-custom.service.ts
@@ -153,7 +153,7 @@ export class DelegationAdminCustomService {
     }
   }
 
-  async createDelegationByZendeskId(zendeskId: string): Promise<void> {
+  async createDelegationByZendeskId(zendeskId: string): Promise<DelegationDTO> {
     const zendeskCase = await this.zendeskService.getTicket(zendeskId)
 
     const {
@@ -181,13 +181,15 @@ export class DelegationAdminCustomService {
 
     this.verifyTicketCompletion(zendeskCase)
 
-    await this.insertDelegation({
+    const resp = await this.insertDelegation({
       fromNationalId,
       toNationalId,
       referenceId: zendeskId,
       validTo: this.formatZendeskDate(validTo),
       createdBy: createdByNationalId,
     })
+
+    return resp.toDTO(AuthDelegationType.GeneralMandate)
   }
 
   async createDelegation(

diff --git a/libs/auth-api-lib/src/lib/delegations/dto/delegation.dto.ts b/libs/auth-api-lib/src/lib/delegations/dto/delegation.dto.ts
@@ -45,6 +45,10 @@ export class DelegationDTO {
   @ApiProperty()
   toNationalId!: string
 
+  @IsString()
+  @ApiPropertyOptional()
+  createdByNationalId?: string
+
   @IsString()
   @ApiPropertyOptional({ nullable: true, type: String })
   toName?: string | null

diff --git a/libs/auth-api-lib/src/lib/delegations/models/delegation.model.ts b/libs/auth-api-lib/src/lib/delegations/models/delegation.model.ts
@@ -141,6 +141,7 @@ export class Delegation extends Model<
       fromNationalId: this.fromNationalId,
       toNationalId: this.toNationalId,
       toName: this.toName,
+      createdByNationalId: this.createdByNationalId,
       validTo: this.validTo,
       scopes: this.delegationScopes
         ? this.delegationScopes.map((scope) => scope.toDTO())