audit log delegation-admin webhook

island-is · Oct 9, 2024 · 6449052 · 6449052
1 parent 68290a6
commit 6449052
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/apps/services/auth/admin-api/src/app/v2/delegations/delegation-admin.controller.ts b/apps/services/auth/admin-api/src/app/v2/delegations/delegation-admin.controller.ts
@@ -99,6 +99,7 @@ export class DelegationAdminController {
   @BypassAuth()
   @UseGuards(new ZendeskAuthGuard(env.zendeskGeneralMandateWebhookSecret))
   @Post('/zendesk')
+  @Audit<{ id: string }>({ resources: (body) => body.id })
   @Documentation({
     response: { status: 200 },
   })

diff --git a/apps/services/auth/delegation-api/src/app/delegations/delegation-index.controller.ts b/apps/services/auth/delegation-api/src/app/delegations/delegation-index.controller.ts
@@ -88,6 +88,7 @@ export class DelegationIndexController {
       {
         auth: auth,
         action: 'createOrUpdateDelegationIndexItem',
+        namespace,
         resources: delegationIndexId,
         meta: {
           ...parsedDelegationInfo,
@@ -123,6 +124,7 @@ export class DelegationIndexController {
     await this.auditService.auditPromise(
       {
         auth: auth,
+        namespace,
         action: 'removeDelegationIndexItem',
         resources: delegationIndexId,
         meta: {

diff --git a/libs/auth-api-lib/src/lib/delegations/delegations-index.service.ts b/libs/auth-api-lib/src/lib/delegations/delegations-index.service.ts
@@ -310,8 +310,8 @@ export class DelegationsIndexService {
     const [updatedDelegation] = await this.auditService.auditPromise(
       {
         auth,
-        action:
-          '@island.is/auth/delegation-index/create-or-update-delegation-record',
+        action: 'create-or-update-delegation-record',
+        namespace: '@island.is/auth/delegation-index',
         resources: delegation.toNationalId,
         alsoLog: true,
         meta: {
@@ -334,7 +334,8 @@ export class DelegationsIndexService {
     await this.auditService.auditPromise(
       {
         auth,
-        action: '@island.is/auth/delegation-index/remove-delegation-record',
+        action: 'remove-delegation-record',
+        namespace: '@island.is/auth/delegation-index',
         resources: delegation.toNationalId,
         alsoLog: true,
         meta: {
@@ -438,7 +439,8 @@ export class DelegationsIndexService {
     // is the common place to audit updates in the index.
     this.auditService.audit({
       auth,
-      action: '@island.is/auth/delegation-index/save-to-index',
+      action: 'save-to-index',
+      namespace: '@island.is/auth/delegation-index',
       alsoLog: true,
       resources: nationalId,
       meta: {