Skip to content
This repository was archived by the owner on Apr 20, 2026. It is now read-only.

add nginx frontend containers#128

Merged
ishandhanani merged 3 commits intomainfrom
grho/feb2_b
Feb 2, 2026
Merged

add nginx frontend containers#128
ishandhanani merged 3 commits intomainfrom
grho/feb2_b

Conversation

@gracehonv
Copy link
Copy Markdown
Collaborator

@gracehonv gracehonv commented Feb 2, 2026

Summary by CodeRabbit

  • Chores
    • Added explicit frontend nginx container references across multiple environment profiles for consistent container selection.
    • Removed a legacy filesystem mount mapping from one profile to simplify configuration and deployment.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 2, 2026

Warning

Rate limit exceeded

@ishandhanani has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 53 minutes and 53 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📝 Walkthrough

Walkthrough

Adds frontend.nginx_container: nginx to three gb300-fp8 recipe YAMLs and removes an extra_mount entry that mounted /lustre from one recipe; no other keys or logic were changed.

Changes

Cohort / File(s) Summary
Frontend nginx_container
recipes/gb300-fp8/1k8k/stp/low-latency.yaml, recipes/gb300-fp8/1k8k/stp/max.yaml, recipes/gb300-fp8/1k8k/stp/mid.yaml
Adds frontend.nginx_container: nginx to each recipe’s frontend configuration.
Removed mount mapping
recipes/gb300-fp8/8k1k/stp/max.yaml
Removes the extra_mount block that mounted /lustre into the container.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • trevor-m
  • kyleliang-nv

Poem

🐰 I tweaked three recipes, neat and clean,
nginx now fronts the service scene,
one old mount hopped away today,
the kitchen’s lighter—hip hooray! 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'add nginx frontend containers' accurately summarizes the main changes: adding nginx_container configurations to multiple YAML files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch grho/feb2_b

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ishandhanani ishandhanani merged commit 5966406 into main Feb 2, 2026
1 of 5 checks passed
ishandhanani added a commit that referenced this pull request Feb 2, 2026
* add nginx frontend containers

* lustre

* lustre

---------

Co-authored-by: Grace Ho <grho@login-lyris02.lyris.clusters.nvidia.com>
Co-authored-by: ishandhanani <ishandhanani@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants