Skip to content
This repository was archived by the owner on Apr 20, 2026. It is now read-only.

gb300 - cleanups#126

Merged
ishandhanani merged 2 commits intomainfrom
gb300-fixes
Feb 2, 2026
Merged

gb300 - cleanups#126
ishandhanani merged 2 commits intomainfrom
gb300-fixes

Conversation

@ishandhanani
Copy link
Copy Markdown
Owner

@ishandhanani ishandhanani commented Feb 2, 2026

Summary by CodeRabbit

  • Chores
    • Updated the model runtime across multiple recipes for improved performance and compatibility.
  • New Features
    • Added nginx frontend support to multiple recipe configurations for easier deployments.
    • Enabled additional storage mounting in select recipes to improve data access.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 2, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Updated GB300-FP8 recipe YAMLs (1k1k and 8k1k variants) to use a new model.container image ("lmsysorg/sglang:v0.5.8-cu130-runtime") and add a frontend.nginx_container: nginx entry; some files also include or retain extra_mount entries (e.g., /lustre).

Changes

Cohort / File(s) Summary
1k1k Recipe Configurations
recipes/gb300-fp8/1k1k/stp/low-latency.yaml, recipes/gb300-fp8/1k1k/stp/max.yaml, recipes/gb300-fp8/1k1k/stp/mid.yaml
Replaced legacy model.container image with lmsysorg/sglang:v0.5.8-cu130-runtime. Added frontend.nginx_container: nginx. Minor formatting around existing extra_mount in mid.yaml.
8k1k Recipe Configurations
recipes/gb300-fp8/8k1k/stp/low-latency.yaml, recipes/gb300-fp8/8k1k/stp/mid.yaml, recipes/gb300-fp8/8k1k/stp/max.yaml
Replaced model.container image with lmsysorg/sglang:v0.5.8-cu130-runtime. Added frontend.nginx_container: nginx across files. mid.yaml and max.yaml include or retain extra_mount for /lustre.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • trevor-m
  • kyleliang-nv

Poem

🐇 Containers hop to a newer tune,

images gleam beneath the moon,
nginx hums a frontend song,
recipes tidy, neat, and strong,
I nibble bugs and skip along.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'gb300 - cleanups' is vague and non-descriptive. It does not convey the specific changes made, which are updating container images and adding frontend nginx configuration across multiple YAML files. Use a more specific title that describes the actual changes, such as 'Update sglang container image and add nginx frontend configuration' or 'Upgrade gb300 container images to v0.5.8 and configure frontend'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch gb300-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ishandhanani ishandhanani merged commit 5cad2d9 into main Feb 2, 2026
0 of 5 checks passed
ishandhanani added a commit that referenced this pull request Feb 2, 2026
* init

* mised
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant