Skip to content

Fixes rl_games workflow's log_root_path to be the absolute path #3531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+5 −5
Open

Fixes rl_games workflow's log_root_path to be the absolute path #3531

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
49ae4ba
Fixes abs path for logdir when pbt is not used
sbtc-sipbb Sep 23, 2025
4beeb5d
Merge branch 'main' into fix/rl_games-log
garylvov Oct 7, 2025
bd11e26
Merge branch 'main' into fix/rl_games-log
ozhanozen Oct 17, 2025
fe6d188
add explicit RL games experiment name
garylvov Oct 20, 2025
53f4091
Merge branch 'main' into fix/rl_games-log
garylvov Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions scripts/reinforcement_learning/rl_games/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,11 +127,10 @@ def main(env_cfg: ManagerBasedRLEnvCfg | DirectRLEnvCfg | DirectMARLEnvCfg, agen
# specify directory for logging experiments
config_name = agent_cfg["params"]["config"]["name"]
log_root_path = os.path.join("logs", "rl_games", config_name)
if "pbt" in agent_cfg:
if agent_cfg["pbt"]["directory"] == ".":
log_root_path = os.path.abspath(log_root_path)
else:
log_root_path = os.path.join(agent_cfg["pbt"]["directory"], log_root_path)
if "pbt" in agent_cfg and agent_cfg["pbt"]["directory"] != ".":
log_root_path = os.path.join(agent_cfg["pbt"]["directory"], log_root_path)
else:
log_root_path = os.path.abspath(log_root_path)

print(f"[INFO] Logging experiment in directory: {log_root_path}")
# specify directory for logging runs
Expand All @@ -146,6 +145,7 @@ def main(env_cfg: ManagerBasedRLEnvCfg | DirectRLEnvCfg | DirectMARLEnvCfg, agen
# dump the configuration into log-directory
dump_yaml(os.path.join(log_root_path, log_dir, "params", "env.yaml"), env_cfg)
dump_yaml(os.path.join(log_root_path, log_dir, "params", "agent.yaml"), agent_cfg)
print(f"Exact experiment name requested from command line: {os.path.join(log_root_path, log_dir)}")

# read configurations about the agent-training
rl_device = agent_cfg["params"]["config"]["device"]
Expand Down
Loading