Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Relaxing gymnasium requirement #1002

Closed
BurakDmb opened this issue Sep 19, 2024 · 5 comments · Fixed by #1446
Closed

[Proposal] Relaxing gymnasium requirement #1002

BurakDmb opened this issue Sep 19, 2024 · 5 comments · Fixed by #1446
Labels
enhancement New feature or request

Comments

@BurakDmb
Copy link

Proposal

Hi, for some other libraries, I am forced to use Gymnasium version 0.29.1.
However, Isaaclab has a 0.29.0 strict requirement.

and

Can you bump Gymnasium to 0.29.1 or at least relax the requirement to cover both 0.29.0 and 0.29.1

0.29.1 is a minor release and it only adds some small warnings, so I don't think anything will break in IsaacLab.
https://github.com/Farama-Foundation/Gymnasium/releases/tag/v0.29.1

I can open a PR if help is needed.

@BurakDmb BurakDmb changed the title [Proposal] Relaxing gymnasium requirement to 0.29.1 [Proposal] Relaxing gymnasium requirement Sep 19, 2024
@Mayankm96
Copy link
Contributor

Mayankm96 commented Sep 19, 2024

We can relax it but then it becomes hard to ensure that things aren't breaking because other libraries made breaking changes.

Checking the diff between 0.29.0 and 0.29.1, I think we can do an update of that (provided everything works). But I'd be against making it always ">=".

@BurakDmb
Copy link
Author

I suggest a version specifier like this could cover your concerns and flex the version by a little bit.
I tested in my local setup for pip installation and setup py seems to be working.
Source for specifying range in install_requires: https://packaging.python.org/en/latest/discussions/install-requires-vs-requirements/#install-requires

"gymnasium >=0.29.0, <=0.29.1"

@BurakDmb
Copy link
Author

Hi, I can create a PR for that, or is someone working on this now?
Do you happen to see any problems with this version suggestion? @Mayankm96

My suggestion is changing these lines with "gymnasium >=0.29.0, <=0.29.1" to support gymnasium versions 0.29.0 and 0.29.1:

@Mayankm96
Copy link
Contributor

Gymnasium 1.0.0 is out. We would work on switching to it.

@Toni-SM for vis.

@Mayankm96 Mayankm96 added the enhancement New feature or request label Oct 9, 2024
@cyhunblr
Copy link

Are there any updates regarding this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants