[LinalgExt] MSVC Bug fix - useExp / useExp2 in AggregatedOpInterfaceImpl#23219
Merged
amd-eochoalo merged 1 commit intomainfrom Jan 20, 2026
Merged
[LinalgExt] MSVC Bug fix - useExp / useExp2 in AggregatedOpInterfaceImpl#23219amd-eochoalo merged 1 commit intomainfrom
amd-eochoalo merged 1 commit intomainfrom
Conversation
The original code returns two types, and MSVC refuses to pick a common type. By switching the conditional to return a Value, the types are identical, so MSVC should accept it. Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
keshavvinayak01
requested review from
Groverkss,
IanWood1,
MaheshRavishankar,
Max191 and
hanhanW
as code owners
Contributor
|
@keshavvinayak01 can you make sure to build windows_msvc before merging? You can use ci-extra: windows_x64_msvc |
Contributor
Author
amd-eochoalo
approved these changes
Jan 20, 2026
MaheshRavishankar
pushed a commit
to MaheshRavishankar/iree
that referenced
this pull request
Feb 24, 2026
…mpl (iree-org#23219) The original code returns two types, and MSVC refuses to pick a common type. By switching the conditional to return a Value, the types are identical, so MSVC should accept it. Solves the CI bug raised by iree-org#23211 Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original code returns two types, and MSVC refuses to pick a common type. By switching the conditional to return a Value, the types are identical, so MSVC should accept it.
Solves the CI bug raised by #23211