[LinalgExt] Added toggle for using useExp2 for onlineAttention Decomposition#23211
Merged
Groverkss merged 12 commits intoiree-org:mainfrom Jan 20, 2026
Conversation
keshavvinayak01
requested review from
Groverkss,
IanWood1,
MaheshRavishankar,
Max191 and
hanhanW
as code owners
keshavvinayak01
changed the title
Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
…dd use_exp2 not overwrite Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
Updated computeSubAndExp2 calls to computeSubAndExp with useExp2 flag. Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
keshavvinayak01
force-pushed
the
users/keshavvinayak01/onlineattention-useexp2-toggle-clean
branch
from
33af3f6 to
56e0617
Compare
Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
Groverkss
approved these changes
Jan 20, 2026
Contributor
|
@keshavvinayak01 This PR appears to break the windows build https://github.com/iree-org/iree/actions/runs/21179744109/job/60918483815 can you take a look? |
Contributor
|
C:\home\runner_work\iree\iree\compiler\src\iree\compiler\Dialect\LinalgExt\IR\AggregatedOpInterfaceImpl.cpp(285): error C2446: ':': no conversion from 'mlir::math::ExpOp' to 'mlir::math::Exp2Op' |
Contributor
Author
|
Can solve this with a single line of change. I'll send a PR soon. |
Contributor
Author
keshavvinayak01
added a commit
that referenced
this pull request
Jan 27, 2026
…osition (#23211) Following the discussion from #22441 Depending on the backend, certain computations may benefit from directly using `exp` instead of `exp2`, since there might be accuracy losses due to FP-reassociation. It's helpful to add flag incase the user tracks losses to this particular computation and might favour directly using `exp`. The `use_exp2` flag is mostly unused in dialect conversions and passes, I presume it's used as a KernelOption. The changes here will not modify the default behavior. --------- Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
MaheshRavishankar
pushed a commit
to MaheshRavishankar/iree
that referenced
this pull request
Feb 24, 2026
…osition (iree-org#23211) Following the discussion from iree-org#22441 Depending on the backend, certain computations may benefit from directly using `exp` instead of `exp2`, since there might be accuracy losses due to FP-reassociation. It's helpful to add flag incase the user tracks losses to this particular computation and might favour directly using `exp`. The `use_exp2` flag is mostly unused in dialect conversions and passes, I presume it's used as a KernelOption. The changes here will not modify the default behavior. --------- Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
MaheshRavishankar
pushed a commit
to MaheshRavishankar/iree
that referenced
this pull request
Feb 24, 2026
…mpl (iree-org#23219) The original code returns two types, and MSVC refuses to pick a common type. By switching the conditional to return a Value, the types are identical, so MSVC should accept it. Solves the CI bug raised by iree-org#23211 Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the discussion from #22441
Depending on the backend, certain computations may benefit from directly using
expinstead ofexp2, since there might be accuracy losses due to FP-reassociation. It's helpful to add flag incase the user tracks losses to this particular computation and might favour directly usingexp.The
use_exp2flag is mostly unused in dialect conversions and passes, I presume it's used as a KernelOption. The changes here will not modify the default behavior.