Skip to content

[CI] Skip onnx_ops hip rdna3 tests#23190

Merged
amd-eochoalo merged 3 commits intoiree-org:mainfrom
amd-eochoalo:eochoa/2026-01-19/skip-tests
Jan 19, 2026
Merged

[CI] Skip onnx_ops hip rdna3 tests#23190
amd-eochoalo merged 3 commits intoiree-org:mainfrom
amd-eochoalo:eochoa/2026-01-19/skip-tests

Conversation

@amd-eochoalo
Copy link
Contributor

These tests have been failing since #22813 . An issue has been filed in #23189

@amd-eochoalo amd-eochoalo changed the title [CI] Skip onnx_ops amdgpu tests [CI] Skip onnx_ops hip rdna3 tests Jan 19, 2026
@amd-eochoalo
Copy link
Contributor Author

Relevant tests are passing. Merging.

@amd-eochoalo amd-eochoalo merged commit 97611b9 into iree-org:main Jan 19, 2026
54 of 56 checks passed
@MaheshRavishankar
Copy link
Collaborator

Just to clarify, all of these have some sort of control flow in the generated IR on input?

@amd-eochoalo
Copy link
Contributor Author

I can't answer that at the moment since I am building IREE for the integrate. I'll double check once I have a few cycles and revert the necessary changes. I understand now what you meant when you said "disable only [the tests without any dispatches]"

@MaheshRavishankar
Copy link
Collaborator

I can't answer that at the moment since I am building IREE for the integrate. I'll double check once I have a few cycles and revert the necessary changes. I understand now what you meant when you said "disable only [the tests without any dispatches]"

Lets take these one by one... we can have a quick sync where we can just check what the IR looks like after global opt phase and I can let you know what to do with these.

@amd-eochoalo
Copy link
Contributor Author

@MaheshRavishankar sounds good, let me revert and tomorrow I can look into this in more detail.

@amd-eochoalo
Copy link
Contributor Author

@MaheshRavishankar I've reverted them here #23199

@MaheshRavishankar
Copy link
Collaborator

Its OK, if you are going to look at it soon, no need to revert.. you can just enable them as we look at it.

@amd-eochoalo
Copy link
Contributor Author

Here is the list of reasons why tests are failing

test reason
test_gru_seq_length hangs
test_rnn_seq_length hangs
test_scan9_sum hangs
test_stft_with_window hangs
test_tfidfvectorizer_tf_batch_onlybigrams_skip0 Does not generate any dispatches
test_tfidfvectorizer_tf_batch_onlybigrams_skip5 Does not generate any dispatches
test_tfidfvectorizer_tf_batch_uniandbigrams_skip5 Does not generate any dispatches

Based on this I'll look a little bit closer into the first four, keep the last three as skips.

@MaheshRavishankar
Copy link
Collaborator

Here is the list of reasons why tests are failing

test reason
test_gru_seq_length hangs
test_rnn_seq_length hangs
test_scan9_sum hangs
test_stft_with_window hangs
test_tfidfvectorizer_tf_batch_onlybigrams_skip0 Does not generate any dispatches
test_tfidfvectorizer_tf_batch_onlybigrams_skip5 Does not generate any dispatches
test_tfidfvectorizer_tf_batch_uniandbigrams_skip5 Does not generate any dispatches
Based on this I'll look a little bit closer into the first four, keep the last three as skips.

If you post the input after global optimizations somewhere I can help make a decision on this.

@amd-eochoalo
Copy link
Contributor Author

I'll have this later today. Thanks!

keshavvinayak01 pushed a commit that referenced this pull request Jan 27, 2026
These tests have been failing since
#22813 . An issue has been filed in
#23189

Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants