Adding SCF support to AutomaticReferenceCountingPass.#22813
Merged
Conversation
benvanik
added
the
compiler/dialects
benvanik
force-pushed
the
users/benvanik/arc-scf
branch
from
6f4b866 to
335e133
Compare
benvanik
force-pushed
the
users/benvanik/elide-update
branch
from
adb4057 to
fb7d0a4
Compare
benvanik
force-pushed
the
users/benvanik/arc-scf
branch
from
335e133 to
102c67c
Compare
benvanik
force-pushed
the
users/benvanik/arc-scf
branch
from
102c67c to
b5987fc
Compare
benvanik
force-pushed
the
users/benvanik/elide-update
branch
from
fb7d0a4 to
2d679e9
Compare
AWoloszyn
approved these changes
Dec 10, 2025
benvanik
force-pushed
the
users/benvanik/elide-update
branch
from
2d679e9 to
db89706
Compare
benvanik
force-pushed
the
users/benvanik/arc-scf
branch
from
b5987fc to
245e2a3
Compare
Adds comprehensive support for SCF control flow ops (scf.for, scf.if, scf.while) to the pass. - ScopedTimepointCoverage: Replaces LocalTimepointCoverage with scope-aware timepoint tracking that properly handles nested regions and control flow - SCF op handlers: analyzeForLoop, analyzeIfOp, analyzeWhileOp that correctly track resources across region boundaries - Resource yield prevention: Ensures resources captured by control flow regions are properly handled to prevent use-after-free - Cross-scope timepoint coverage: Joins timepoints at scope boundaries for correct deallocation ordering The pass now properly handles programs with SCF control flow instead of bailing out when any SCF ops are present in a function.
benvanik
force-pushed
the
users/benvanik/arc-scf
branch
from
245e2a3 to
ebbc387
Compare
This was referenced Jan 19, 2026
amd-eochoalo
added a commit
that referenced
this pull request
Jan 19, 2026
Contributor
keshavvinayak01
pushed a commit
that referenced
this pull request
Jan 27, 2026
Adds comprehensive support for SCF control flow ops (scf.for, scf.if, scf.while) to the pass. - ScopedTimepointCoverage: Replaces LocalTimepointCoverage with scope-aware timepoint tracking that properly handles nested regions and control flow - SCF op handlers: analyzeForLoop, analyzeIfOp, analyzeWhileOp that correctly track resources across region boundaries - Resource yield prevention: Ensures resources captured by control flow regions are properly handled to prevent use-after-free - Cross-scope timepoint coverage: Joins timepoints at scope boundaries for correct deallocation ordering The pass now properly handles programs with SCF control flow instead of bailing out when any SCF ops are present in a function. Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
keshavvinayak01
pushed a commit
that referenced
this pull request
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds comprehensive support for SCF control flow ops (scf.for, scf.if, scf.while) to the pass.
The pass now properly handles programs with SCF control flow instead of bailing out when any SCF ops are present in a function.
(most of this was authored with claude)