Skip to content

[Codegen] Fix compiler errors in LinkTuningSpecsPass #23169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kuhar merged 1 commit into from
Jan 16, 2026
+4 −8
Merged

[Codegen] Fix compiler errors in LinkTuningSpecsPass #23169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions compiler/src/iree/compiler/Codegen/Common/LinkTuningSpecsPass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,12 +409,8 @@ static FailureOr<NamedSequenceOp> emitLinkedDefaultTuningSpec(ModuleOp module) {
SmallVector<Attribute> mergedActions;

for (ForeachMatchOp foreachMatchOp : foreachMatchOps) {
ArrayAttr matchers = foreachMatchOp.getMatchers();
ArrayAttr actions = foreachMatchOp.getActions();
for (auto [matcher, action] : llvm::zip_equal(matchers, actions)) {
mergedMatchers.push_back(cast<SymbolRefAttr>(matcher));
mergedActions.push_back(cast<SymbolRefAttr>(action));
}
llvm::append_range(mergedMatchers, foreachMatchOp.getMatchers());
llvm::append_range(mergedActions, foreachMatchOp.getActions());
Comment on lines +412 to +413
Copy link
Collaborator

@bjacob bjacob Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the sorting change intentional? (zipped -> not zipped).

Copy link
Member Author

@kuhar kuhar Jan 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand. There's no difference AFAICT.

Copy link
Collaborator

@bjacob bjacob Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry, I misread. Thought we were appending to the same vector, but those are two distinct vectors.

}

Region &region = newEntryPoint.getRegion();
Expand All @@ -423,8 +419,8 @@ static FailureOr<NamedSequenceOp> emitLinkedDefaultTuningSpec(ModuleOp module) {
builder.setInsertionPointToStart(body);
auto mergedForeachMatch = ForeachMatchOp::create(
builder, loc, resultTypes, newEntryPoint.getArgument(0),
/* forwarded_inputs = */ ValueRange(),
/* restrictRoot = */ nullptr, /* flattenResults = */ nullptr,
/*forwarded_inputs=*/ValueRange(),
/*restrict_root=*/false, /*flatten_results=*/false,
builder.getArrayAttr(mergedMatchers),
builder.getArrayAttr(mergedActions));
transform::YieldOp::create(builder, loc, mergedForeachMatch->getResult(0));
Expand Down
Loading