[Codegen] Fix compiler errors in LinkTuningSpecsPass#23169
Merged
kuhar merged 1 commit intoiree-org:mainfrom Jan 16, 2026
Merged
[Codegen] Fix compiler errors in LinkTuningSpecsPass#23169kuhar merged 1 commit intoiree-org:mainfrom
kuhar merged 1 commit intoiree-org:mainfrom
Conversation
kuhar
requested review from
MaheshRavishankar,
Max191,
benvanik and
hanhanW
as code owners
Pass booleans instead of `nullptr`; the former confuses some compilers because both `bool` and `Value` are constructible with `nullptr`. Also clean up comments and needlesly complicated code just above.
kuhar
force-pushed
the
link-tuning-specs-fixes
branch
from
c5ee902 to
308f126
Compare
bjacob
reviewed
Jan 16, 2026
Comment on lines
+412
to
+413
| llvm::append_range(mergedMatchers, foreachMatchOp.getMatchers()); | ||
| llvm::append_range(mergedActions, foreachMatchOp.getActions()); |
Collaborator
There was a problem hiding this comment.
Is the sorting change intentional? (zipped -> not zipped).
Member
Author
There was a problem hiding this comment.
I don't understand. There's no difference AFAICT.
Collaborator
There was a problem hiding this comment.
oh sorry, I misread. Thought we were appending to the same vector, but those are two distinct vectors.
bjacob
approved these changes
Jan 16, 2026
keshavvinayak01
pushed a commit
that referenced
this pull request
Jan 27, 2026
Pass booleans instead of `nullptr`; the former confuses some compilers because both `bool` and `Value` are constructible with `nullptr`. Also clean up comments and needlessly complicated code just above. Fixes: #23164 Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
MaheshRavishankar
pushed a commit
to MaheshRavishankar/iree
that referenced
this pull request
Feb 24, 2026
Pass booleans instead of `nullptr`; the former confuses some compilers because both `bool` and `Value` are constructible with `nullptr`. Also clean up comments and needlessly complicated code just above. Fixes: iree-org#23164
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass booleans instead of
nullptr; the former confuses some compilers because bothboolandValueare constructible withnullptr.Also clean up comments and needlessly complicated code just above.
Fixes: #23164