Skip to content

[BOO] Add split reduction and global optimization flags #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yzhang93 merged 4 commits into from
Nov 3, 2025
Merged

[BOO] Add split reduction and global optimization flags #1195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f9f55e
[BOO] Add split reduction and global optimization flags
yzhang93 Oct 31, 2025
64f4626
Merge branch 'main' into users/yzhang93/split_reduction_flag
yzhang93 Nov 3, 2025
0e5dcb5
Only force single dispatch on forward
yzhang93 Nov 3, 2025
af37f9d
Merge branch 'main' into users/yzhang93/split_reduction_flag
yzhang93 Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion iree/turbine/kernel/boo/op_exports/layer_norm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def output_shape(self) -> list[int]:

@property
def force_single_dispatch(self) -> bool:
return True
return self.mode == Mode.FORWARD

@staticmethod
def get(
Expand Down
3 changes: 3 additions & 0 deletions iree/turbine/kernel/boo/runtime/launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,9 @@ def default_compiler_flags_callback(device: Device, cache_dir: Path) -> list[str
flags.append(
"--iree-dispatch-creation-enable-fuse-padding-into-linalg-consumer-ops"
)
flags.append("--iree-dispatch-creation-enable-split-reduction")
# Temporary flags to transpose filter layout without fusing into the computation dispatch.
flags.append("--iree-global-opt-experimental-enable-edge-reshape-propagation")
Comment on lines +234 to +236
Copy link
Copy Markdown
Member

@IanWood1 IanWood1 Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want some comments explaining why they were added? And in the case of iree-global-opt-experimental-enable-edge-reshape-propagation, saying that it should only be a temporary flag.

flags.append(
"--iree-preprocessing-pass-pipeline=builtin.module(iree-preprocessing-convert-conv-filter-to-channels-last)"
)
Expand Down
Loading