[BOO] Add split reduction and global optimization flags#1195
Merged
Conversation
yzhang93
force-pushed
the
users/yzhang93/split_reduction_flag
branch
from
0f1ee33 to
407fd26
Compare
rkayaith
approved these changes
Oct 31, 2025
Member
rkayaith
left a comment
rkayaith
left a comment
There was a problem hiding this comment.
We'll have to bump the IREE pin before this can be merged
IanWood1
reviewed
Oct 31, 2025
Comment on lines
+234
to
+235
| flags.append("--iree-dispatch-creation-enable-split-reduction") | ||
| flags.append("--iree-global-opt-experimental-enable-edge-reshape-propagation") |
Member
There was a problem hiding this comment.
Do we want some comments explaining why they were added? And in the case of iree-global-opt-experimental-enable-edge-reshape-propagation, saying that it should only be a temporary flag.
yzhang93
force-pushed
the
users/yzhang93/split_reduction_flag
branch
from
407fd26 to
2f9f55e
Compare
Signed-off-by: yzhang93 <zhyuhang88@gmail.com>
Member
|
The IREE bunp is merged now, once you rebase this should be good. |
Signed-off-by: yzhang93 <zhyuhang88@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding two flags: