Revert to CFITSIO for table i/o #379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olebole
force-pushed
the
revert-to-cfitsio
branch
from
4706204
to
40b284f
Compare
The libtbtables.a was changed in v2.16 to use SPP fitsio from earlier uses of the fortran version under the assumption that they were equivalent. However, there is a bug in the fortran version of ftdrow() when called by the TDIFFER task in which the output table doesn't have its NAXIS2 value properly updated for FITS tables causing the task to exit. The cfitsio code acknowledges the value may not be correct and so uses an internal data structure value for the 'nrows' rather than the keyword, but equivalent functionality does not exist in the fortran version. A similar problem exists when inserting rows but this is not called from any existing NTTOOLS tasks. This change fixes a bug in the GEMINI.GSEEING task which is the only task known to call TDIFFER.
olebole
force-pushed
the
revert-to-cfitsio
branch
from
0e02b0e
to
5572b61
Compare
olebole
force-pushed
the
revert-to-cfitsio
branch
3 times, most recently
from
e2e4182
to
1faabee
Compare
|
As NOIRLab IRAF now moved cfitsio to a central place ( Although there is an issue to discuss this (iraf-v218!12), they prefer not to answer there. Yet another communication highlight with NOIRLab. 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from NOIRLABs IRAF, 5d4c168, author @mjfitzpatrick
This PR however has a number of disadvantages: first the cfitsio version is quite old, so that many platforms are unsupported. Then, cfitsio is platform dependent and therefore should be part of the HSI and not part of an application package. And finally, cfitsio is used in other packages (st4gem, fitsutil), and it is probably not a good idea to have the same code (maybe in different versions) several times.