Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #961 +/- ##
==========================================
+ Coverage 94.29% 94.37% +0.07%
==========================================
Files 159 162 +3
Lines 17344 17687 +343
==========================================
+ Hits 16355 16692 +337
- Misses 989 995 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
5e9c460 to
7f9d123
Compare
ccc3776 to
90c05f4
Compare
056e8ae to
a919431
Compare
e19a72a to
3ff5253
Compare
Member
|
|
gumb0
commented
Feb 10, 2025
chfast
reviewed
Feb 10, 2025
chfast
reviewed
Feb 10, 2025
gumb0
commented
Feb 10, 2025
chfast
reviewed
Feb 10, 2025
chfast
reviewed
Feb 10, 2025
chfast
reviewed
Feb 10, 2025
Member
chfast
left a comment
There was a problem hiding this comment.
There are some artificial enviroments where this can crash:
- having invalid delegation designator in state,
- having a precompile with code.
Do you think we should add sanity checks for these when loading tests?
chfast
requested changes
Feb 10, 2025
chfast
reviewed
Feb 11, 2025
gumb0
commented
Feb 12, 2025
gumb0
commented
Feb 12, 2025
gumb0
commented
Feb 12, 2025
Member
Author
I think it makes sense to add in a separate PR |
gumb0
commented
Feb 12, 2025
chfast
approved these changes
Feb 12, 2025
Co-authored-by: Paweł Bylica <pawel@ethereum.org>
Co-authored-by: Paweł Bylica <pawel@ethereum.org>
Co-authored-by: Paweł Bylica <pawel@ethereum.org>
Co-authored-by: pdobacz <5735525+pdobacz@users.noreply.github.com>
Co-authored-by: pdobacz <5735525+pdobacz@users.noreply.github.com> Co-authored-by: Paweł Bylica <pawel@ethereum.org>
Add required MODEXP stub value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement EIP-7702: Set EOA account code. This EIP adds new transaction type set-code that permanently sets the code delegation for an EOA.
Requires new EVMC flag: ipsilon/evmc#720.