Add prestate validation checks to state test loader#1134
Merged
Conversation
gumb0
force-pushed
the
test/check-pre-state
branch
from
fb524cf to
a7dbe62
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1134 +/- ##
==========================================
- Coverage 94.54% 93.97% -0.58%
==========================================
Files 168 168
Lines 18254 18292 +38
==========================================
- Hits 17259 17189 -70
- Misses 995 1103 +108
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
gumb0
force-pushed
the
test/check-pre-state
branch
7 times, most recently
from
d84257e to
acdc602
Compare
gumb0
force-pushed
the
test/check-pre-state
branch
from
acdc602 to
adc15ef
Compare
chfast
approved these changes
Feb 24, 2025
Member
chfast
left a comment
chfast
left a comment
There was a problem hiding this comment.
LGTM.
I think we should submit a PR to EEST with the test removal. This may start a longer discussion there, but this is fine.
Then we can wait until the discussion is resolved and merge this, or merge it before.
test/statetest/statetest_loader.cpp
Outdated
|
|
||
| #include "../utils/stdx/utility.hpp" | ||
| #include "../utils/utils.hpp" | ||
| #include "evmone/delegation.hpp" |
Member
There was a problem hiding this comment.
Suggested change
| #include "evmone/delegation.hpp" | |
| #include <evmone/delegation.hpp> |
test/statetest/statetest_loader.cpp
Outdated
| #include "../utils/utils.hpp" | ||
| #include "evmone/delegation.hpp" | ||
| #include "statetest.hpp" | ||
| #include "test/state/precompiles.hpp" |
Member
There was a problem hiding this comment.
Suggested change
| #include "test/state/precompiles.hpp" | |
| #include <test/state/precompiles.hpp> |
gumb0
force-pushed
the
test/check-pre-state
branch
from
adc15ef to
4a87fba
Compare
chfast
force-pushed
the
test/check-pre-state
branch
from
4a87fba to
ce99eb3
Compare
gumb0
force-pushed
the
test/check-pre-state
branch
2 times, most recently
from
87d4289 to
b812b48
Compare
chfast
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idea originated in #961 (review)