Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #909 +/- ##
==========================================
+ Coverage 95.29% 95.33% +0.03%
==========================================
Files 138 138
Lines 15485 15615 +130
==========================================
+ Hits 14757 14887 +130
Misses 728 728
Flags with carried forward coverage won't be shown. Click here to find out more.
|
3279611 to
1283104
Compare
1283104 to
a174634
Compare
chfast
approved these changes
Jun 3, 2024
a174634 to
5948039
Compare
7 tasks
5948039 to
f976b45
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #896, implements ipsilon/eof#90 / ethereum/EIPs#8617 the simplest way - by checking two first bytes of code on every instructions.
A better version would be to store the result in ExecutionState, and the best to use an entirely different instruction table in
dispatchfunctions.Should we do the
ExecutionStateversion right away now, or keep as is? Anyway, opening as draft until the EOF pr doesn't get merged (should be decided on the next eof impl call)