Test EIP-7069 Address Space Extension implications by shemnon · Pull Request #522 · ethereum/execution-spec-tests

shemnon · 2024-04-23T21:18:13Z

🗒️ Description

Validate ASE behaviors on legacy and EOF opcodes for ASE, when targeting
EOAs, Contracts, and empty accounts. Opcodes are EXTCALL/CALL,
EXTDELEGATECALL/DELEGATECALL, EXTSTATICCALL/STATICCALL, and CALLCODE.

🔗 Related Issues

✅ Checklist

All: Set appropriate labels for the changes.
All: Considered squashing commits to improve commit history.
All: Added an entry to CHANGELOG.md.
All: Considered updating the online docs in the ./docs/ directory.
Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

tests/prague/eip7676_address_space_extension/test_ase_opcodes.py

Validate ASE behaviors on legacy and EOF opcodes for ASE, when targeting EOAs, Contracts, and empty accounts. Opcodes are BALANCE, EXTCALL/CALL, EXTDELEGATECALL/DELEGATECALL, EXTSTATICCALL/STATICCALL, and CALLCODE. Signed-off-by: Danno Ferrin <danno@numisight.com>

Signed-off-by: Danno Ferrin <danno@numisight.com>

EIP-7676 moved the critical EXTCALL sections into the main spec. EOF does not depend on a new BALANCE op, so don't test it. Signed-off-by: Danno Ferrin <danno@numisight.com>

…eof/ase

Signed-off-by: Danno Ferrin <danno@numisight.com>

marioevz

Just a comment about the pattern used to write these tests.

tests/prague/eip7692_eof_v1/eip7676_address_space_extension/test_ase_opcodes.py

Signed-off-by: Danno Ferrin <danno@numisight.com>

shemnon · 2024-05-23T17:13:51Z

Since 7979 is out of scope for EOFv1 I migrated this into a 7069 test that only tests the ASE aspects.

marioevz

It looks really good overall, but one change I would probably do is:

Instead of doing all types of calls in a single shot, maybe we could simply parameterize for each call opcode.

Reason being that, running the tests like this makes it difficult to single out the failing ones to a single opcode with an incorrect behavior, but if it was parameterized, it would be very easy to do this, even if it comes at the cost of having to run more tests.

tests/prague/eip7692_eof_v1/eip7069_extcall/test_address_space_extension.py

* Apply specific edits * Parameterize by opcode as well Signed-off-by: Danno Ferrin <danno@numisight.com>

…eof/ase

Signed-off-by: Danno Ferrin <danno@numisight.com>

shemnon · 2024-05-28T23:02:36Z

Refactored so it's parameterized on opcode. However the logic to determine the "correct" output is still in place. The other alternative is 7 slightly different versions of the test and parameters, dropping most if the conditional building.

tests/prague/eip7692_eof_v1/eip7069_extcall/test_address_space_extension.py

marioevz

Some comments, thanks!

tests/prague/eip7692_eof_v1/eip7069_extcall/test_address_space_extension.py

marioevz · 2024-06-03T19:10:38Z

One last comment I forgot in the review (sorry), I think variables with the addresses could be renamed like this:
address_caller -> address_entry_point
address_target -> address_caller

Because, currently, there is target_address but it does not match what is being placed in the pre-alloc IMO.

…eof/ase

Remove RETURNDATALOAD from ASE tests, to be moved to a different test Signed-off-by: Danno Ferrin <danno@numisight.com>

Signed-off-by: Danno Ferrin <danno@numisight.com>

tests/prague/eip7692_eof_v1/eip7069_extcall/test_address_space_extension.py

tests/prague/eip7692_eof_v1/eip7069_extcall/spec.py

marioevz

Some more comments after another review pass.

tests/prague/eip7692_eof_v1/eip7069_extcall/test_address_space_extension.py

Signed-off-by: Danno Ferrin <danno@numisight.com>

All changes have been addressed.

marioevz

LGTM.

…ereum#522) * Validate EIP-7676 Prepare for Address Space Extension Validate ASE behaviors on legacy and EOF opcodes for ASE, when targeting EOAs, Contracts, and empty accounts. Opcodes are BALANCE, EXTCALL/CALL, EXTDELEGATECALL/DELEGATECALL, EXTSTATICCALL/STATICCALL, and CALLCODE. Signed-off-by: Danno Ferrin <danno@numisight.com> * Reviewer requested changes Signed-off-by: Danno Ferrin <danno@numisight.com> * formatting Signed-off-by: Danno Ferrin <danno@numisight.com> * speling Signed-off-by: Danno Ferrin <danno@numisight.com> * comment out balance from ASE checks EIP-7676 moved the critical EXTCALL sections into the main spec. EOF does not depend on a new BALANCE op, so don't test it. Signed-off-by: Danno Ferrin <danno@numisight.com> * move to new subfolder Signed-off-by: Danno Ferrin <danno@numisight.com> * Recast as EIP-7069 test Signed-off-by: Danno Ferrin <danno@numisight.com> * use itertools.count instead of hard coded address Signed-off-by: Danno Ferrin <danno@numisight.com> * Review changes * Apply specific edits * Parameterize by opcode as well Signed-off-by: Danno Ferrin <danno@numisight.com> * tox fixes Signed-off-by: Danno Ferrin <danno@numisight.com> * remove RETURNDATALOAD from ASE tests Remove RETURNDATALOAD from ASE tests, to be moved to a different test Signed-off-by: Danno Ferrin <danno@numisight.com> * reviewer comments Signed-off-by: Danno Ferrin <danno@numisight.com> * Reviewer comments Signed-off-by: Danno Ferrin <danno@numisight.com> * extreneous changes Signed-off-by: Danno Ferrin <danno@numisight.com> --------- Signed-off-by: Danno Ferrin <danno@numisight.com>

shemnon force-pushed the eof/ase branch from 4f5f84a to 3ed99a0 Compare April 23, 2024 21:33

winsvega self-requested a review April 24, 2024 13:20

winsvega previously requested changes Apr 24, 2024

View reviewed changes

tests/prague/eip7676_address_space_extension/test_ase_opcodes.py Outdated Show resolved Hide resolved

tests/prague/eip7676_address_space_extension/test_ase_opcodes.py Outdated Show resolved Hide resolved

shemnon force-pushed the eof/ase branch from 3ed99a0 to b005113 Compare April 24, 2024 13:33

shemnon added 3 commits April 24, 2024 13:20

Reviewer requested changes

52be716

Signed-off-by: Danno Ferrin <danno@numisight.com>

formatting

f5dd04a

Signed-off-by: Danno Ferrin <danno@numisight.com>

speling

b88130d

Signed-off-by: Danno Ferrin <danno@numisight.com>

shemnon marked this pull request as ready for review May 9, 2024 19:32

shemnon added 3 commits May 13, 2024 12:44

comment out balance from ASE checks

2966ef5

EIP-7676 moved the critical EXTCALL sections into the main spec. EOF does not depend on a new BALANCE op, so don't test it. Signed-off-by: Danno Ferrin <danno@numisight.com>

Merge branch 'main' of github.com:ethereum/execution-spec-tests into …

eb0badf

…eof/ase

move to new subfolder

6c3a028

Signed-off-by: Danno Ferrin <danno@numisight.com>

marioevz reviewed May 23, 2024

View reviewed changes

tests/prague/eip7692_eof_v1/eip7676_address_space_extension/test_ase_opcodes.py Outdated Show resolved Hide resolved

Recast as EIP-7069 test

7882ef0

Signed-off-by: Danno Ferrin <danno@numisight.com>

shemnon changed the title ~~Validate EIP-7676 Prepare for Address Space Extension~~ Test EIP-7069 Address Space Extension implications May 23, 2024

use itertools.count instead of hard coded address

988996b

Signed-off-by: Danno Ferrin <danno@numisight.com>

marioevz reviewed May 28, 2024

View reviewed changes

shemnon added 3 commits May 28, 2024 16:43

Review changes

4ecae63

* Apply specific edits * Parameterize by opcode as well Signed-off-by: Danno Ferrin <danno@numisight.com>

Merge branch 'main' of github.com:ethereum/execution-spec-tests into …

a979246

…eof/ase

tox fixes

97ed1e1

Signed-off-by: Danno Ferrin <danno@numisight.com>

marioevz reviewed Jun 3, 2024

View reviewed changes

tests/prague/eip7692_eof_v1/eip7069_extcall/test_address_space_extension.py Outdated Show resolved Hide resolved

marioevz reviewed Jun 3, 2024

View reviewed changes

tests/prague/eip7692_eof_v1/eip7069_extcall/test_address_space_extension.py Outdated Show resolved Hide resolved

marioevz reviewed Jun 3, 2024

View reviewed changes

shemnon added 3 commits June 4, 2024 14:32

Merge branch 'main' of github.com:ethereum/execution-spec-tests into …

2a7b7d5

…eof/ase

remove RETURNDATALOAD from ASE tests

4754460

Remove RETURNDATALOAD from ASE tests, to be moved to a different test Signed-off-by: Danno Ferrin <danno@numisight.com>

reviewer comments

338ff16

Signed-off-by: Danno Ferrin <danno@numisight.com>

chfast requested changes Jun 5, 2024

View reviewed changes

tests/prague/eip7692_eof_v1/eip7069_extcall/test_address_space_extension.py Outdated Show resolved Hide resolved

pdobacz reviewed Jun 5, 2024

View reviewed changes

tests/prague/eip7692_eof_v1/eip7069_extcall/spec.py Outdated Show resolved Hide resolved

marioevz reviewed Jun 5, 2024

View reviewed changes

shemnon mentioned this pull request Jun 6, 2024

new(tests) EIP-7069 RETURNDATALOAD and RETURNDATACOPY #595

Merged

7 tasks

shemnon added 3 commits June 6, 2024 12:38

merge main

53953cc

Signed-off-by: Danno Ferrin <danno@numisight.com>

Reviewer comments

95e5bc0

Signed-off-by: Danno Ferrin <danno@numisight.com>

extreneous changes

8698b1f

Signed-off-by: Danno Ferrin <danno@numisight.com>

marioevz approved these changes Jun 6, 2024

View reviewed changes

marioevz merged commit 53fc6d8 into ethereum:main Jun 6, 2024

Conversation

shemnon commented Apr 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🗒️ Description

🔗 Related Issues

✅ Checklist

Uh oh!

Uh oh!

Uh oh!

marioevz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shemnon commented May 23, 2024

Uh oh!

marioevz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shemnon commented May 28, 2024

Uh oh!

Uh oh!

Uh oh!

marioevz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marioevz commented Jun 3, 2024

Uh oh!

Uh oh!

Uh oh!

marioevz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marioevz left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

shemnon commented Apr 23, 2024 •

edited

Loading