-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unite the Files API 🗂 #98
Comments
There is also currently |
Also the names are long established so even if This separation is meaningful from interworks perspective but from user perspective it makes almost no sense. I can say that most of my |
This may also be a signal that the A slightly more radical idea is to break these out into separate commands altogether, and have |
Action items:
|
@whyrusleeping could you elaborate on the point number two: |
What i was thinking was this: Every call to
|
Unifying |
@Kubuxu could you confirm, AFAIK |
Oh, there isn't |
@Kubuxu there isnt an issue, |
Or we can wait for 0.5 where we introduce CIDv1 so there the pain of changing hash function (which is the case) is much smaller and can be easily checked for (version byte). |
The hashes will not "change totally" in 0.5. The default object format will change so adding the same content on 0.5 will produce a different hash than adding that content with 0.4. You will still be able to select the old hashing and chunking/encoding format as an option to add and get the same output as before. Also, old hashes will still be accessible and available, all thats happening is a change in defaults. |
Can we have this as one of the discussions for Monday Sprint hangouts? //cc @RichardLitt @em-ly @flyingzumwalt It seems to me that we have all the information we need to move forward :) |
I added this to the agenda for the all-hands call. That's a chance to briefly tell everyone about the issue, make sure everyone knows that the breakout discussion will be happening, and find out who wants to be included in that discussion. |
I don't full understand why this is bad:
|
|
Yeah i think that would solve all our problems, no?
|
Slightly related ipfs/kubo#2811 as how ever this is solved might solve that issue. |
mfs
to the commands that are part of mfs
, call files
to the basic adding and getting files commands
Just to keep record. Me and @whyrusleeping had a quick chat whole we were together in Lisbon and we agreed that #98 (comment) is a good way to go next. @whyrusleeping please Ack just to make sure we continue in sync :) |
I believe this discussion continues in https://github.com/ipfs/interface-js-ipfs-core/issues/284 |
Several of our users have been mislead to think of IPFS of File System instead of a Graph Database (fair point that is the name of the project after all:D). This mostly comes from the fact that the
cat
,get
andadd
commands come as first order commands and are the ones mostly used by demos.Now, with the addition of the 'Files API', another layer of complexity and indirection was added. The common reaction to it is "Wait, what is Files API, weren't we adding Files all this time?".
With this, we miss the chance to lead our users to understand what a great Graph Database primitives IPFS offers and we also make it really hard for users to understand what Files API is, specially when it has such a generic name.
So, were is the proposal (this is not just me, although I'm the one writing it) that we've discussed through several points in time.
Rename the Files API to
mfs
, this will enable us to have one non generic keyword to call it that we can use with our users and also something that the community will be able to search for or aspect specially, since it has very technical details.Move the
cat
,get
andadd
commands to under the files umbrela.In practical terms, this means:
Next:
The text was updated successfully, but these errors were encountered: