Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improved error message on broken CIDv0 #7807

Merged
merged 1 commit into from
Jan 14, 2021
Merged

fix: improved error message on broken CIDv0 #7807

merged 1 commit into from
Jan 14, 2021

Conversation

lidel
Copy link
Member

@lidel lidel commented Dec 7, 2020 •
edited
Loading

Closes #7792

$ ipfs files stat /ipfs/qmbwqxbekc3p8tqskc98xmwnzrzdtrlmimpl8wbutgsmnr
Error: invalid path "/ipfs/qmbwqxbekc3p8tqskc98xmwnzrzdtrlmimpl8wbutgsmnr": invalid CID: selected encoding not supported (possible lowercased CIDv0; consider converting to a case-agnostic CIDv1, such as base32)

Would be cool to squeeze this in go-ipfs 0.8.0.

@lidel lidel added the topic/cidv1b32 Topic cidv1b32 label Dec 7, 2020
@lidel lidel mentioned this pull request Jan 7, 2021
Merged
@lidel lidel added the need/review Needs a review label Jan 7, 2021
@lidel lidel marked this pull request as ready for review January 7, 2021 19:48
@aschmahmann aschmahmann merged commit 651e3cc into master Jan 14, 2021
@aschmahmann aschmahmann deleted the fix/broken-cidv0-ux branch January 14, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschmahmann aschmahmann aschmahmann approved these changes

Assignees
No one assigned
Labels
need/review Needs a review topic/cidv1b32 Topic cidv1b32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error when broken CIDv0 is used
2 participants
@lidel @aschmahmann