Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce go modules [yey] #6038

Merged
merged 31 commits into from
Mar 5, 2019
Merged

Introduce go modules [yey] #6038

merged 31 commits into from
Mar 5, 2019

Conversation

Kubuxu
Copy link
Member

@Kubuxu Kubuxu commented Mar 2, 2019 •
edited
Loading

Makefiles and CI were adapted.

socat commit: f9392ed

@ghost ghost assigned Kubuxu Mar 2, 2019
@ghost ghost added the status/in-progress In progress label Mar 2, 2019
@Kubuxu Kubuxu force-pushed the feat/gomod-yey branch 4 times, most recently from 0c79b28 to 0bbacb6 Compare March 3, 2019 18:37
@Kubuxu
Copy link
Member Author

Kubuxu commented Mar 3, 2019

gotest is broken because our JUnit test results generation is broken in general. Waiting for @magik6k to fix it.

@Kubuxu
Copy link
Member Author

Kubuxu commented Mar 4, 2019

I have killed all uses of netcat inside sharness tests because differences between bsd and gnu netcat were making me mad. I've replaced it with socat which is more complex but better suited for the job in most places.

@Kubuxu Kubuxu force-pushed the feat/gomod-yey branch 2 times, most recently from f8fd836 to a9ffcda Compare March 4, 2019 02:50
@Kubuxu
Copy link
Member Author

Kubuxu commented Mar 4, 2019

@Stebalien this PR completly removed gx from Makefiles. It was much easier to do than to try to negotate gomod with gx.

Is this OK solution? How do yo feel about it. What would be the next step to getting this merged?

@Kubuxu Kubuxu marked this pull request as ready for review March 4, 2019 03:08
@Kubuxu
Copy link
Member Author

Kubuxu commented Mar 4, 2019

A more useful commit range: https://github.com/ipfs/go-ipfs/pull/6038/files/a1b0c0309d0d95e4386eba58658825b487918573..68c1035ad4641a58332484d5ff9b5f73c4a63a76

@Kubuxu Kubuxu force-pushed the feat/gomod-yey branch 7 times, most recently from 6b4fc5b to b3fdae3 Compare March 4, 2019 22:16
@Kubuxu
Copy link
Member Author

Kubuxu commented Mar 4, 2019

I've fixed JUnit for gotest generation and cleaned the circleci config a bit.

@Kubuxu Kubuxu force-pushed the feat/gomod-yey branch 2 times, most recently from 4f5164c to 3cbe677 Compare March 4, 2019 23:38
@Stebalien Stebalien requested a review from magik6k March 4, 2019 23:58
@Stebalien
Copy link
Member

Is the socat change going to cause trouble for macos users?

@Kubuxu
Copy link
Member Author

Kubuxu commented Mar 5, 2019 •
edited
Loading

socat is available on brew: https://brewinstall.org/Install-socat-on-Mac-with-Brew/

@Stebalien
Copy link
Member

(will merge once @magik6k signs off on it)

@Kubuxu Kubuxu force-pushed the feat/gomod-yey branch 2 times, most recently from a203fa8 to e5fea20 Compare March 5, 2019 09:59
@Kubuxu
circleci: rework pipeline
4e8cc7f 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
gomod: remove gopath check
21f3dae 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
gomod: update go-libp2p-pubsub-router
bd70568 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
travis: remove TravisCI, if someone wants to fix it, be my guest
44d8288 
Having a red status check only means that it is ok to see red there.
This shouldn't be the norm as it makes us ignore status checks.
It is the same case with random test failures.

License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
circleci: run try-build target on ci
d2a2e14 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
misc: add collect-profiles.sh script, update gitignore
e575c93 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
gomod/mk: set GO111MODULE in Makefile
76f7a76 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
magik6k
magik6k reviewed Mar 5, 2019
View reviewed changes
Copy link
Member

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 tiny note + makeshould export GO111MODULE=on

test/unit/Rules.mk Show resolved Hide resolved
@Kubuxu
mk: remove json-to-junit program
c21b7f9 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
magik6k
magik6k approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@Stebalien Stebalien merged commit fdc1b76 into master Mar 5, 2019
@ghost ghost removed the status/in-progress In progress label Mar 5, 2019
@Stebalien
Copy link
Member

🚀

@Stebalien Stebalien deleted the feat/gomod-yey branch March 5, 2019 17:47
@Kubuxu
Copy link
Member Author

Kubuxu commented Mar 5, 2019

Yey. Put it on a boat.

@magik6k magik6k mentioned this pull request Mar 8, 2019
Closed
@andrew andrew mentioned this pull request Mar 11, 2019
Closed
@b5 b5 mentioned this pull request Apr 3, 2019
Closed
17 tasks
This was referenced Apr 4, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 27, 2023
@Stebalien
Merge pull request ipfs/kubo#6038 from ipfs/feat/gomod-yey
29cf932 
Introduce go modules [yey]

This commit was moved from ipfs/kubo@fdc1b76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@magik6k magik6k magik6k approved these changes

Assignees

@Kubuxu Kubuxu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kubuxu @Stebalien @magik6k