-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce go modules [yey] #6038
Conversation
0c79b28
to
0bbacb6
Compare
|
I have killed all uses of |
f8fd836
to
a9ffcda
Compare
@Stebalien this PR completly removed Is this OK solution? How do yo feel about it. What would be the next step to getting this merged? |
6b4fc5b
to
b3fdae3
Compare
I've fixed JUnit for gotest generation and cleaned the circleci config a bit. |
4f5164c
to
3cbe677
Compare
Is the socat change going to cause trouble for macos users? |
|
(will merge once @magik6k signs off on it) |
a203fa8
to
e5fea20
Compare
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
Having a red status check only means that it is ok to see red there. This shouldn't be the norm as it makes us ignore status checks. It is the same case with random test failures. License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 tiny note + make
should export GO111MODULE=on
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
🚀 |
Yey. Put it on a boat. |
Introduce go modules [yey] This commit was moved from ipfs/kubo@fdc1b76
Makefiles and CI were adapted.
socat commit: f9392ed