Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bubble up go-logging fixes #3486

Closed
whyrusleeping opened this issue Dec 8, 2016 · 6 comments
Closed

bubble up go-logging fixes #3486

whyrusleeping opened this issue Dec 8, 2016 · 6 comments
Labels
help wanted Seeking public contribution on this issue

Comments

@whyrusleeping
Copy link
Member

Since whyrusleeping/go-logging#1

will resolve #3383
@whyrusleeping whyrusleeping added the status/ready Ready to be worked label Dec 8, 2016
@whyrusleeping whyrusleeping added the help wanted Seeking public contribution on this issue label Mar 7, 2017
@whyrusleeping whyrusleeping modified the milestones: Ipfs 0.4.7, Ipfs 0.4.8 Mar 7, 2017
@whyrusleeping
Copy link
Member Author

Lets try to do this in 0.4.8

@whyrusleeping whyrusleeping modified the milestones: Ipfs 0.4.9, Ipfs 0.4.8 Mar 24, 2017
@whyrusleeping
Copy link
Member Author

Has this been done? go-ipfs is using the latest version of go-log (1.2.0) but i'm not sure if that actually resolves this issue

@whyrusleeping whyrusleeping modified the milestones: Ipfs 0.4.10, Ipfs 0.4.9 May 2, 2017
@kevina
Copy link
Contributor

kevina commented May 3, 2017

It doesn't look like it. I looked at the code currently used by go-log "gx/ipfs/QmQvJiADDe7JR4m968MwXobTCCzUqQkP87aRHe29MEBGHV" and it does not include the fix.

@magik6k magik6k modified the milestones: Ipfs 0.4.10, Ipfs 0.4.11 Jul 28, 2017
@Kubuxu Kubuxu modified the milestones: Ipfs 0.4.12, go-ipfs 0.4.13 Nov 6, 2017
sanderpick added a commit to textileio/go-log that referenced this issue Nov 21, 2018
@sanderpick
update go-logging
de66281 
re: ipfs/kubo#3486
@sanderpick
Copy link
Contributor

Looked at this earlier because I'm getting hit by the thread safety issue addressed by this fix: whyrusleeping/go-logging@04b9b69

tl;dr spinning up multiple nodes in tests causes a concurrent map read. I updated go-log w/ latest whyrusleeping/go-logging, then realized go-log is scattered throughout sub-packages... any advice on how to automate something like that?

@sanderpick
Copy link
Contributor

Interesting, bumped to go 1.11.2 from 1.10.4 and go-ipfs 0.4.18 and am no longer seeing the concurrent map read panic. ¯_(ツ)_/¯.

Happy Thanksgiving y'all!

@Stebalien Stebalien added status/deferred Conscious decision to pause or backlog and removed status/ready Ready to be worked labels Dec 18, 2018
@Kubuxu
Copy link
Member

Kubuxu commented Apr 4, 2019 •
edited
Loading

Not relevant anymore. #6038

@Kubuxu Kubuxu closed this as completed Apr 4, 2019
@ghost ghost removed the status/deferred Conscious decision to pause or backlog label Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Seeking public contribution on this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Stebalien @sanderpick @whyrusleeping @kevina @Kubuxu @magik6k