-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bubble up go-logging fixes #3486
Comments
Lets try to do this in 0.4.8 |
Has this been done? go-ipfs is using the latest version of go-log (1.2.0) but i'm not sure if that actually resolves this issue |
It doesn't look like it. I looked at the code currently used by go-log "gx/ipfs/QmQvJiADDe7JR4m968MwXobTCCzUqQkP87aRHe29MEBGHV" and it does not include the fix. |
Looked at this earlier because I'm getting hit by the thread safety issue addressed by this fix: whyrusleeping/go-logging@04b9b69 tl;dr spinning up multiple nodes in tests causes a concurrent map read. I updated |
Interesting, bumped to go 1.11.2 from 1.10.4 and go-ipfs 0.4.18 and am no longer seeing the concurrent map read panic. ¯_(ツ)_/¯. Happy Thanksgiving y'all! |
Not relevant anymore. #6038 |
Since whyrusleeping/go-logging#1
will resolve #3383
The text was updated successfully, but these errors were encountered: