bitswap/workers: fix proc / ctx wiring #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the order of the proc/ctx wiring, to ensure that the proc has been setup correctly before exiting. License: MIT Signed-off-by: Juan Batiz-Benet <[email protected]>
|
@whyrusleeping i fixed that proc bug |
jbenet
added a commit
that referenced
this pull request
Sep 5, 2015
bitswap/workers: fix proc / ctx wiring
|
tests??? |
|
@whyrusleeping in the prev config, it's an odd race. i dont know of a reliable way to repro other than run travis a ton of times. |
|
(happy to add something if you have a good suggestion) |
|
yeah, i'm not really sure. yay race conditionssss |
| <-px.Closing() // process closes first | ||
| cancelFunc() | ||
| }() | ||
| procctx.CloseAfterContext(px, ctx) // parent cancelled first |
There was a problem hiding this comment.
What's the reason that bitswap.New has WithCancel but dht.NewDHT doesn't?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the order of the proc/ctx wiring, to ensure
that the proc has been setup correctly before exiting.
License: MIT
Signed-off-by: Juan Batiz-Benet [email protected]