-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
an attempt at making the editor more efficient #1567
Conversation
@whyrusleeping SGTM. the right solution, i think |
Cool, I'll finish working it into the add command if you'd like. |
|
||
func (e *Editor) WriteOutputTo(ds dag.DAGService) error { | ||
return copyDag(e.GetNode(), e.ds, ds) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't seem to get called? shouldn't it be called by the add command at the end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's called now.
3333b81
to
48b115f
Compare
I broke some test here... I'll need to take a look. |
@jbenet if you get a chance, could you take a look at the test failure here in |
Spelunking i also found this:
the |
@@ -153,3 +148,32 @@ func rmLink(ctx context.Context, ds dag.DAGService, root *dag.Node, path []strin | |||
|
|||
return root, nil | |||
} | |||
|
|||
func (e *Editor) WriteOutputTo(ds dag.DAGService) error { | |||
return copyDag(e.GetNode(), e.ds, ds) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this needs what i wrote in 978c9fa#diff-bd0ca9f1e2d5c7ba128af01ec4c1131cR314
In my run (the hashes are different because we use
and
This may be related to something i ran into when i wrote 978c9fa:
|
@whyrusleeping I think I CRed this already. see #1567 (comment) -- otherwise LGTM |
48b115f
to
991cd4c
Compare
@jbenet fixed this! should be good to go. |
@whyrusleeping: 991cd4c committed sadhack.
.... err, i meant
|
@jbenet nuuuuu. the more i have to do this, the more resolve i get to fix the problem in the first place |
991cd4c
to
920f557
Compare
License: MIT Signed-off-by: Jeromy <[email protected]>
License: MIT Signed-off-by: Jeromy <[email protected]>
…eOutputTo License: MIT Signed-off-by: Jeromy <[email protected]>
920f557
to
b3aee28
Compare
Rebased on top of #1655 |
an attempt at making the editor more efficient
Using this, we would be able to pass an 'offline' dagstore to the editor, and then use the
WriteOutputTo
method on the editor to write the changed nodes to our actual dagservice.@jbenet thoughts?
License: MIT
Signed-off-by: Jeromy [email protected]