Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup the p2p command #4895

Closed
Stebalien opened this issue Mar 29, 2018 · 1 comment
Closed

Fixup the p2p command #4895

Stebalien opened this issue Mar 29, 2018 · 1 comment
Assignees
@magik6k
Labels
help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws)

Comments

@Stebalien
Copy link
Member

This command looks like it could use some serious cleanup.

  1. Listeners have Running flags that are (1) never set to false, and (2) not atomic (so setting them to false would be useless anyways).
  2. The registry has no synchronization and is pretty inefficient.

And probably more. Any takers?
@Stebalien Stebalien added kind/bug A bug in existing code (including security flaws) help wanted Seeking public contribution on this issue labels Mar 29, 2018
@Stebalien
Copy link
Member Author

Stebalien commented Mar 29, 2018 •
edited
Loading

More: Make it actually work like ssh -L. It should forward every connection, not just the first. See #4894 (comment).

@Stebalien Stebalien mentioned this issue Mar 29, 2018
Closed
@magik6k magik6k self-assigned this Apr 5, 2018
@magik6k magik6k mentioned this issue Apr 10, 2018
Merged
5 tasks
@ghost ghost added the status/in-progress In progress label Apr 10, 2018
@magik6k magik6k mentioned this issue May 23, 2018
Open
Stebalien added a commit that referenced this issue Jun 26, 2018
@Stebalien
gx update
8f11aa8 
Updates:

* go-kad-dht: Query performance improvements, DHT client fixes, validates
  records on *local* put.
* go-libp2p-swarm/go-libp2p-transport: Timeout improvements.
* go-multiaddr-net: Exposes useful Conn methods (CloseWrite, CloseRead, etc.)
* go-log: fixes possible panic when enabling/disabling events.
* go-multiaddr: fixes possible panic when stringifying malformed multiaddrs,
  adds support for consuming /p2p/ multiaddrs.

fixes #5113
unblocks #4895

License: MIT
Signed-off-by: Steven Allen <[email protected]>
@Stebalien Stebalien mentioned this issue Jun 27, 2018
Merged
2 tasks
Stebalien added a commit that referenced this issue Jun 27, 2018
@Stebalien
gx update
3eba14a 
Updates:

* go-kad-dht: Query performance improvements, DHT client fixes, validates
  records on *local* put.
* go-libp2p-swarm/go-libp2p-transport: Timeout improvements.
* go-multiaddr-net: Exposes useful Conn methods (CloseWrite, CloseRead, etc.)
* go-log: fixes possible panic when enabling/disabling events.
* go-multiaddr: fixes possible panic when stringifying malformed multiaddrs,
  adds support for consuming /p2p/ multiaddrs.

fixes #5113
unblocks #4895

License: MIT
Signed-off-by: Steven Allen <[email protected]>
@ghost ghost removed the status/in-progress In progress label Sep 13, 2018
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Feb 25, 2022
@Stebalien
gx update
806561f 
Updates:

* go-kad-dht: Query performance improvements, DHT client fixes, validates
  records on *local* put.
* go-libp2p-swarm/go-libp2p-transport: Timeout improvements.
* go-multiaddr-net: Exposes useful Conn methods (CloseWrite, CloseRead, etc.)
* go-log: fixes possible panic when enabling/disabling events.
* go-multiaddr: fixes possible panic when stringifying malformed multiaddrs,
  adds support for consuming /p2p/ multiaddrs.

fixes ipfs#5113
unblocks ipfs#4895

License: MIT
Signed-off-by: Steven Allen <[email protected]>
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Feb 25, 2022
@Stebalien
go-ipfs-config: gx update
f9dd701 
Updates:

* go-kad-dht: Query performance improvements, DHT client fixes, validates
  records on *local* put.
* go-libp2p-swarm/go-libp2p-transport: Timeout improvements.
* go-multiaddr-net: Exposes useful Conn methods (CloseWrite, CloseRead, etc.)
* go-log: fixes possible panic when enabling/disabling events.
* go-multiaddr: fixes possible panic when stringifying malformed multiaddrs,
  adds support for consuming /p2p/ multiaddrs.

fixes ipfs#5113
unblocks ipfs#4895

License: MIT
Signed-off-by: Steven Allen <[email protected]>
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Mar 4, 2022
@Stebalien
go-ipfs-config: gx update
7fded30 
Updates:

* go-kad-dht: Query performance improvements, DHT client fixes, validates
  records on *local* put.
* go-libp2p-swarm/go-libp2p-transport: Timeout improvements.
* go-multiaddr-net: Exposes useful Conn methods (CloseWrite, CloseRead, etc.)
* go-log: fixes possible panic when enabling/disabling events.
* go-multiaddr: fixes possible panic when stringifying malformed multiaddrs,
  adds support for consuming /p2p/ multiaddrs.

fixes ipfs#5113
unblocks ipfs#4895

License: MIT
Signed-off-by: Steven Allen <[email protected]>
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Apr 7, 2022
@Stebalien
gx update
0821b4d 
Updates:

* go-kad-dht: Query performance improvements, DHT client fixes, validates
  records on *local* put.
* go-libp2p-swarm/go-libp2p-transport: Timeout improvements.
* go-multiaddr-net: Exposes useful Conn methods (CloseWrite, CloseRead, etc.)
* go-log: fixes possible panic when enabling/disabling events.
* go-multiaddr: fixes possible panic when stringifying malformed multiaddrs,
  adds support for consuming /p2p/ multiaddrs.

fixes ipfs#5113
unblocks ipfs#4895

License: MIT
Signed-off-by: Steven Allen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magik6k magik6k

Labels
help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @magik6k