Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type mismatch panic on ipfs add #4683

Closed
whyrusleeping opened this issue Feb 12, 2018 · 4 comments · Fixed by ipfs/go-ipfs-cmds#66 or #4724
Closed

type mismatch panic on ipfs add #4683

whyrusleeping opened this issue Feb 12, 2018 · 4 comments · Fixed by ipfs/go-ipfs-cmds#66 or #4724
Assignees

Comments

@whyrusleeping
Copy link
Member

whyrusleeping commented Feb 12, 2018

Verision
./ipfs version --all
go-ipfs version: 0.4.14-dev-eca0486e1
Repo version: 6
System version: amd64/linux
Golang version: go1.9.4

Output

IPFS_PATH="/data/ipfsrepo"  IPFS_FD_MAX="4096" ./ipfs add --progress --local --nocopy --fscache --quieter --recursive mirror/
 
 849.23 GB / 849.35 GB [==========================================================================================================================================]  99.99% 0s
panic: interface conversion: interface {} is cmdkit.Error, not *coreunix.AddedObject

goroutine 70 [running]:
github.com/ipfs/go-ipfs/core/commands.glob..func7.2(0xc42001a3c0)
        /home/alvaro/gocode/src/github.com/ipfs/go-ipfs/core/commands/add.go:405 +0xa60
created by github.com/ipfs/go-ipfs/core/commands.glob..func7.3
        /home/alvaro/gocode/src/github.com/ipfs/go-ipfs/core/commands/add.go:467 +0xc7
@whyrusleeping
Copy link
Member Author

reported in #3885

@Stebalien
Copy link
Member

Effectively, ipfs/go-ipfs-cmds#62. We shouldn't be using the same logic for errors and values.

@rngkll
Copy link

rngkll commented Feb 14, 2018

Let us know if you need help reproducing the issue, are running the command daily.

We will like to help on fixing this.

@whyrusleeping
Copy link
Member Author

@rngkll I've got a patch that fixes the issue (linked above your comment on github). We're working on determining if its the 'right' fix, or just a hack that works for now that we may regret later. Its an issue in our newly refactored command RPC library.

Stebalien added a commit to ipfs/go-ipfs-cmds that referenced this issue Feb 16, 2018
@ghost ghost assigned Stebalien Feb 16, 2018
@ghost ghost added the status/in-progress In progress label Feb 16, 2018
@ghost ghost removed the status/in-progress In progress label Feb 20, 2018
Stebalien added a commit that referenced this issue Feb 21, 2018
* May fix #4670
* Fixes #4683

License: MIT
Signed-off-by: Steven Allen <[email protected]>
AFDudley pushed a commit to vulcanize/go-ipfs that referenced this issue Mar 22, 2018
* May fix ipfs#4670
* Fixes ipfs#4683

License: MIT
Signed-off-by: Steven Allen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants