-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return errors from cmds.Copy directly #64
Conversation
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
- Coverage 44% 43.95% -0.05%
==========================================
Files 23 23
Lines 1925 1927 +2
==========================================
Hits 847 847
- Misses 938 939 +1
- Partials 140 141 +1
Continue to review full report at Codecov.
|
This might be a problem if multiple errors are emitted, but I am not sure yet. Right now I don't think we do it and it could be that emitting multiple errors was part of the original design, but only @keks can know for sure. |
License: MIT Signed-off-by: Kevin Atkinson <[email protected]>
License: MIT Signed-off-by: Kevin Atkinson <[email protected]>
As far as I can tell, this code is already doing what it's supposed to do. |
I believe the correct fix is #66. The other |
This changes the output of the
Now it is just
The last error not emitted is the error returned from the GC() function, which is concerning. This needs to sorted out. |
Fixes the issue seen in ipfs/kubo#4683 But i'm not 100% sure this is the right way.
cc @kevina, you mentioned you could help look into cmds lib issues.