Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enumerate the tests in order to make sure that execa is as robust as subcommandante #95

Closed
daviddias opened this issue Aug 15, 2016 · 6 comments
Assignees

Comments

@daviddias
Copy link
Member

As discussed in August 15 js-ipfs sprint meeting. @jbenet please enumerate all the tests you would like to see for: #89

//cc @JGAntunes

@jbenet
Copy link
Member

jbenet commented Aug 22, 2016

@diasdavid no sorry I don't have time for this in the next 2 weeks. If you
want me to this it probably won't get done for a while.
On Mon, Aug 15, 2016 at 17:00 David Dias [email protected] wrote:

Assigned #95 #95 to @jbenet
https://github.com/jbenet.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#95 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAIcoW4vFe9u4AfL4xneNWF3011-jCDZks5qgNN7gaJpZM4JkxEZ
.

@jbenet
Copy link
Member

jbenet commented Aug 22, 2016

The burden of proof also lies on whoever wants to change the behavior.
Its up to that PR to ensure correctness
On Sun, Aug 21, 2016 at 21:24 Juan Benet [email protected] wrote:

@diasdavid no sorry I don't have time for this in the next 2 weeks. If you
want me to this it probably won't get done for a while.
On Mon, Aug 15, 2016 at 17:00 David Dias [email protected] wrote:

Assigned #95 #95 to @jbenet
https://github.com/jbenet.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#95 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAIcoW4vFe9u4AfL4xneNWF3011-jCDZks5qgNN7gaJpZM4JkxEZ
.

@daviddias
Copy link
Member Author

Ok, I'll handle this myself with @JGAntunes

@daviddias daviddias assigned daviddias and unassigned jbenet Aug 22, 2016
@daviddias daviddias changed the title Enumerate the tests in order to make sure that execa is as robust as subcommandante Enumerate the tests in order to make sure that execa is as robust as subcommandante Nov 10, 2016
@daviddias daviddias added status/ready Ready to be worked and removed js-ipfs-ready labels Dec 5, 2016
@dignifiedquire
Copy link
Member

I found out the hard way that it isn't :(

@daviddias
Copy link
Member Author

Could you elaborate?

@daviddias
Copy link
Member Author

Nvm, saw the commits on #140 (comment), closing this one then :)

@daviddias daviddias removed the status/ready Ready to be worked label Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants