This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
approved these changes
Oct 14, 2019
Just needs green CI & all the gh deps removing from the |
7 tasks
alanshaw
approved these changes
Oct 17, 2019
42 tasks
hugomrdias
changed the title
feat: support the new interface core tests setup
feat: support new ctl api
Dec 10, 2019
hugomrdias
force-pushed
the
feat/interface-tests
branch
2 times, most recently
from
December 10, 2019 23:29
daf3be8
to
8af22a2
Compare
alanshaw
approved these changes
Dec 11, 2019
package.json
Outdated
@@ -160,6 +160,7 @@ | |||
"multihashing-async": "^0.8.0", | |||
"node-fetch": "^2.3.0", | |||
"p-iteration": "^1.1.8", | |||
"p-map": "^3.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move to devDependencies
hugomrdias
force-pushed
the
feat/interface-tests
branch
from
December 11, 2019 12:54
186c886
to
2a809ec
Compare
ready to merge @alanshaw |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the new ipfsd-ctl api.
Enables a bunch more tests in the browser both interface-core and core.
supersedes #2625
/cc @PedroMiguelSS
issues:
#2662
https://github.com/ipfs/interface-js-ipfs-core/issues/570
refs:
ipfs/js-ipfsd-ctl#395
ipfs-inactive/interface-js-ipfs-core#541
ipfs-inactive/js-ipfs-http-client#1127