Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Improve overall state of js-ipfs tests #2276

Closed
21 of 42 tasks
hugomrdias opened this issue Jul 18, 2019 · 4 comments
Closed
21 of 42 tasks

Improve overall state of js-ipfs tests #2276

hugomrdias opened this issue Jul 18, 2019 · 4 comments
Assignees
Labels
awesome endeavour exp/wizard Extensive knowledge (implications, ramifications) required P0 Critical: Tackled by core team ASAP

Comments

@hugomrdias
Copy link
Member

hugomrdias commented Jul 18, 2019

Goals:

  1. Improve developer productivity
  2. Reduce the complexity of adding new tests for core and community devs
  3. Increase overall coverage and quality of the tests

Tasks:

Issues discovered


future work

  • P1 Dependencies between tests needs to be removed
    • js-ipfs cli
  • P1 Environmental skip of tests need to be self applied by each tests (relates to ipfs-utils)
    • ipfsd-ctl
    • interface-core
    • js-ipfs
    • http-client
  • P2 aegir test -t node needs to be reworked
  • P3 HTTP API tests need to have coverage instrumentation (relates to ipfsd-ctl)
  • P4 Browser tests need to build coverage output
  • P4 Test isolation needs to be analysed (daemon spawns between tests)
  • P4 https://github.com/ipfs/interop
  • P4 Travis CI and Windows is still a problem at least for js-ipfs repo
@hugomrdias hugomrdias added exp/wizard Extensive knowledge (implications, ramifications) required awesome endeavour P0 Critical: Tackled by core team ASAP labels Jul 18, 2019
@hugomrdias hugomrdias self-assigned this Jul 18, 2019
@daviddias
Copy link
Member

@hugomrdias as discussed during the OKRs review. It would be great if endeavors like this and others to improve developer productivity such as #1670 had some metrics that capture the improvement. Things suggested to measure:

  • Bundle Size reduction overtime
  • Time to PR to get merged/closed
  • Time to close an Issue
  • Time that tests take to run
  • Number of new contributions from outside core team

@autonome
Copy link
Contributor

autonome commented Oct 1, 2019 via email

@momack2
Copy link
Contributor

momack2 commented Nov 5, 2019

Given the need to start executing on 2020 work next quarter, please plan to finish this testing spike in Q4. That means prioritize your time to ensure we hit the highest priority testing improvements and think about ways to leverage the remaining time on this thread. Something to think about is our iteration velocity here - how do we shorten the cycle of making and shipping testing improvements so we can externalize the value of the work being done quickly?

@hugomrdias
Copy link
Member Author

Going forward after shipping the new ctl PRs, small units of improvement should be much easier to make.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awesome endeavour exp/wizard Extensive knowledge (implications, ramifications) required P0 Critical: Tackled by core team ASAP
Projects
None yet
Development

No branches or pull requests

4 participants