Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Create BRANDING.md #87
docs: Create BRANDING.md #87
Changes from 4 commits
53e36c5
cda563d
363c709
ed0abc0
0f18eda
3fc0f3e
ff55716
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get "access denied", "please request access" or "log in to your account" for all of these links (when not signed in to my PL account).
I think it would be better to store the assets in this repo so they are publicly accessible if we want non-core people to use them.
Licensing is hard though - are we ok to distribute the fonts in this way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - that's why I was asking Crcle to give us ownership or move to our drive so we can move them over. The top level folder is accessible by anyone: https://drive.google.com/drive/folders/1VBRtofco3Gw09VlE9pgCwOGFRwLS6er5?usp=sharing
I'm good with any option here though. We can copy into our own google drive, bring into the repo itself (although I assume there are concerns around adding binary files to a repo), or leave it as is.
My main goal was just to make sure there is a paper trail so a motivated party can get unblocked.
For now I just added a note that many of the links aren't accessible and they should reach out to maintainers for access.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@achingbrain : I copied in assets so we have control. Links (beyond figma) should work.