Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Create BRANDING.md #87

Merged
merged 7 commits into from
Apr 13, 2023
Merged

docs: Create BRANDING.md #87

merged 7 commits into from
Apr 13, 2023

Conversation

BigLep
Copy link
Contributor

@BigLep BigLep commented Apr 11, 2023

No description provided.

@BigLep BigLep requested a review from a team as a code owner April 11, 2023 08:49
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few typos.

For consistency with the other .md files can you add a title and a ToC please?

Do we need a little bit about helia vs Helia, any guidance on using the logo, examples of prose containing the name, etc?

Are people free to use this in stuff in their own projects, put it on their readmes etc? If so maybe a note about that too?

BRANDING.md Outdated Show resolved Hide resolved
BRANDING.md Outdated Show resolved Hide resolved
BigLep and others added 3 commits April 11, 2023 05:41
@BigLep
Copy link
Contributor Author

BigLep commented Apr 11, 2023

Thanks for feedback @achingbrain . I should have been clear that I'm game for you taking this over. I was just trying to kickstart making sure this moved out of private undiscoverable locations.

@BigLep BigLep requested a review from achingbrain April 11, 2023 12:51
BRANDING.md Outdated
Comment on lines 16 to 20
* [Brand sheet](https://www.figma.com/file/Eap42avMitUmvonmFi994R/Helia-Brand-Sheet?node-id=0%3A1&t=kpZjsp4EV34NFfm7-1)
* [Google drive folder with various assets](https://drive.google.com/drive/folders/1VBRtofco3Gw09VlE9pgCwOGFRwLS6er5?usp=sharing)
* [Logos](https://drive.google.com/drive/folders/13tcoTQ6YnAF9u-zYkJShUwCVQ9HXBi75?usp=share_link)
* [Fonts](https://drive.google.com/drive/folders/1GPWn-Y3eSXm1grh4Xr2scAQ6HSM5XwHz?usp=share_link)
* [Google Presentation Slide Template](https://docs.google.com/presentation/d/17bgytPXyHGksqFKs9iQT063CCpQMdxH4dt79VH70DrI/edit)
Copy link
Member

@achingbrain achingbrain Apr 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get "access denied", "please request access" or "log in to your account" for all of these links (when not signed in to my PL account).

I think it would be better to store the assets in this repo so they are publicly accessible if we want non-core people to use them.

Licensing is hard though - are we ok to distribute the fonts in this way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - that's why I was asking Crcle to give us ownership or move to our drive so we can move them over. The top level folder is accessible by anyone: https://drive.google.com/drive/folders/1VBRtofco3Gw09VlE9pgCwOGFRwLS6er5?usp=sharing

I'm good with any option here though. We can copy into our own google drive, bring into the repo itself (although I assume there are concerns around adding binary files to a repo), or leave it as is.

My main goal was just to make sure there is a paper trail so a motivated party can get unblocked.

For now I just added a note that many of the links aren't accessible and they should reach out to maintainers for access.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@achingbrain : I copied in assets so we have control. Links (beyond figma) should work.

BRANDING.md Outdated Show resolved Hide resolved
@achingbrain achingbrain merged commit 55c665e into main Apr 13, 2023
@achingbrain achingbrain deleted the chore/biglep-add-branding.md branch April 13, 2023 20:11
achingbrain pushed a commit that referenced this pull request Jan 8, 2024
Bumps [@libp2p/logger](https://github.com/libp2p/js-libp2p) from 2.1.1 to 3.0.2.
- [Release notes](https://github.com/libp2p/js-libp2p/releases)
- [Changelog](https://github.com/libp2p/js-libp2p/blob/master/.release-please.json)
- [Commits](https://github.com/libp2p/js-libp2p/commits/logger-v3.0.2)

---
updated-dependencies:
- dependency-name: "@libp2p/logger"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
achingbrain pushed a commit that referenced this pull request Jan 8, 2024
achingbrain added a commit that referenced this pull request Jan 8, 2024
Bumps [@helia/interface](https://github.com/ipfs/helia) from 1.2.2 to 2.0.0.
- [Release notes](https://github.com/ipfs/helia/releases)
- [Changelog](https://github.com/ipfs/helia/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ipfs/helia/compare/@helia/interface-v1.2.2...helia-v2.0.0)

---
updated-dependencies:
- dependency-name: "@helia/interface"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: achingbrain <[email protected]>
achingbrain pushed a commit that referenced this pull request Jan 8, 2024
achingbrain added a commit that referenced this pull request Jan 8, 2024
Updates all deps and fixes linting errors.

BREAKING CHANGE: uses multiformats v13 and helia v3
achingbrain pushed a commit that referenced this pull request Jan 8, 2024
## [@helia/strings-v2.0.0](https://github.com/ipfs/helia-strings/compare/@helia/strings-v1.0.1...@helia/strings-v2.0.0) (2024-01-08)

### ⚠ BREAKING CHANGES

* uses multiformats v13 and helia v3

### Features

* update helia to v3 and multiformats to v13 ([#87](ipfs/helia-strings#87)) ([ae7cbc9](ipfs/helia-strings@ae7cbc9))

### Trivial Changes

* update sibling dependencies ([1184ea6](ipfs/helia-strings@1184ea6))
@achingbrain achingbrain mentioned this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants