Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create @helia/verified-fetch #392
feat: create @helia/verified-fetch #392
Changes from 4 commits
2a66379
ab0f994
7a5dc75
8c15f05
94cf631
56008e8
b8a5f67
84adcbb
603fb7f
a49d353
2444ca3
a92ed83
6b42abe
2dd264f
516d896
ccb1739
44c4c20
22cadfe
16a2629
58a2c87
ade40b2
4cc599a
ff25ff1
3f347d8
b11db65
84ef988
71c1b74
0f20f0b
20803f9
b96fd28
fae6ea3
fb5e883
27abe76
3db9838
250ad55
254b94e
129b560
b76e16c
a76b836
a01398a
6e21e06
b32eb7e
e4f4a94
a1e6bf8
1692c61
0290d5e
dee5095
539fe9a
a25d5b0
a40369d
7802acb
aad723a
44d6c82
96adb51
48d960b
5f75863
cb3e95e
0e3a767
6a25298
28a2dc4
9476118
09d8349
0538e24
ce51c89
1747cc2
a55b172
9293622
9b2fa77
8dcb35a
c8f3cff
d0d7fba
fdd8980
f864f44
b177f3e
ec664a8
db3dd3a
deb9c1f
e88b62b
9a0c13c
cb09852
2845b0e
a34119b
c42b99b
8bc259c
b520235
25444d7
99b7066
0e0c287
2d90412
4890b6b
a669b28
97f6cf3
6d05614
08580bf
793ecb4
b488bc9
f1098cf
e073d1f
feac1a0
2491c19
d496d98
53699d0
3da55b9
e21ca11
5d10747
4a514bd
a855339
c590a47
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the initial release, it would be useful to demonstrate value added by the library by having examples similar to https://github.com/ipfs/helia/tree/main/packages/ipns#example---getting-started right in the README.
We already have tests for these, just need to add HTML+JS snippets to README:
dag-cbor
read via.json()
.json()
.text()
<img>
havingsrc
set todata:image/jpg;base64,[...]
with payload read via.arrayBuffer()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the examples are in @packageDocumentation of src/index.ts now and will be copied over to README when merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of this exposition needs to move into the
@packageDocumentation
block of/src/index.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have a discussion about what progress events we actually want
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onProgress events should help answer the following questions:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'if async custom work, should probably have async event':
custom onprogress:
the rest should be piped up from other helia Modules used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should rephrase this to reflect our last Helia WG meeting decision to have this library
We should also note that since this library is not "a gateway" that mimicking every response type will not be possible and that a wrapper library/server would be needed for those cases.