Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 选择符合低basefee条件消息进行推送 / support base fee #253

Merged
merged 3 commits into from
Sep 7, 2022

Conversation

simlecode
Copy link
Collaborator

@simlecode simlecode commented Sep 7, 2022

关联的Issues (Related Issues)

close filecoin-project/venus#5139

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@simlecode simlecode requested a review from diwufeiwen September 7, 2022 05:49
@codecov-commenter
Copy link

Codecov Report

Merging #253 (4d5c266) into master (c824fde) will increase coverage by 0.18%.
The diff coverage is 77.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage   53.74%   53.92%   +0.18%     
==========================================
  Files          63       63              
  Lines        6784     6776       -8     
==========================================
+ Hits         3646     3654       +8     
+ Misses       2839     2821      -18     
- Partials      299      301       +2     
Flag Coverage Δ
unittests 53.92% <77.57%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cli/address.go 0.00% <0.00%> (ø)
cli/shared_params.go 0.00% <0.00%> (ø)
service/shared_params_service.go 70.45% <ø> (+9.67%) ⬆️
testhelper/mock_full_node.go 79.72% <ø> (ø)
service/address_service.go 60.86% <66.66%> (-2.40%) ⬇️
models/mysql/address.go 76.92% <81.25%> (-1.99%) ⬇️
models/mysql/shared_params.go 77.77% <85.71%> (+14.51%) ⬆️
models/sqlite/shared_params.go 84.44% <88.88%> (-1.27%) ⬇️
api/messager_impl.go 83.92% <100.00%> (+1.47%) ⬆️
models/sqlite/address.go 81.53% <100.00%> (+0.28%) ⬆️
... and 6 more

Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diwufeiwen diwufeiwen merged commit 9a72617 into master Sep 7, 2022
@diwufeiwen diwufeiwen deleted the feat/support_base_fee branch September 7, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[venus-messager] 选择低basefee的条件进行消息推送
3 participants